Fixing test module partitioning_warnings #4532
Conversation
There was a problem hiding this comment.
Not sure what exactly is fixed as test still fails and we have changed requirements. There is no missing swap warning on storage-ng, for example. We need to clarify what is expected (e.g. missing /boot/efi for UEFI installations). And we can also verify warning about missing bios-boot.
|
@rwx788, the test was intended to check for this: https://openqa.suse.de/tests/1477724#step/partitioning_warnings/19 It was not trying to catch all possible warnings. It was not trying to catch missing BIOS boot, nor missing EFI. What I don't understand is, why after checking the warnings, we conduct a normal installation: https://openqa.suse.de/tests/1057979#step/partitioning_filesystem/4 overwriting with proposal. |
|
@SergioAtSUSE that's a good point, I guess we can exit after starting the installation. So is this PR WIP then? |
SergioAtSUSE
changed the title
SergioAtSUSE
changed the title
|
Verification run: http://copland.arch.suse.de/tests/963#step/partitioning_warnings/38 |
| @@ -50,7 +49,7 @@ sub run { | |||
| assert_screen 'partition-warning-no-efi-boot'; | |||
| wait_screen_change { send_key 'alt-y' }; # yes | |||
| } | |||
| if (is_storage_ng && !check_screen('partitioning-edit-proposal-button', 0)) { | |||
| if (is_storage_ng && check_screen('partitioning-edit-proposal-button', 0)) { | |||
There was a problem hiding this comment.
We should get rid of this, as bug is resolved and there will be no warning for missing swap, as we have new checkbox for that. So this change doesn't make sense anymore...
- bsc#1055743 - Manually verified partition role with DOS partition table.
- test fail in osd#1509521#step/partitioning_warnings/21
SergioAtSUSE
force-pushed
the
add_bios_boot_part
branch
from
201d1b3
to
43d0c23
Compare
|
New verification run: http://copland.arch.suse.de/tests/966#step/partitioning_warnings/38 Expected to fail there. The workaround should be removed with: https://progress.opensuse.org/issues/31066 |
- bsc#1055744 duplicates bsc#1057049 - bsc#1057049 is verified fixed - bsc#1085131 is the new bug for missing warning
- On storage-ng the warning only appears when swap is mandatory.
SergioAtSUSE
force-pushed
the
add_bios_boot_part
branch
from
43d0c23
to
aca9c0f
Compare
|
New verification run: http://copland.arch.suse.de/tests/969#step/partitioning_warnings/37 |
|
+1, ready to be merged? |
Motivation
Remove invalid soft-failure
Manually verified partition role with DOS partition table.
Add BIOS boot partition
For this test suite it was not added. x86_64 on GTP table needs this partition.