New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test file operations in dolphin #5385

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
6 participants
@Vogtinator
Copy link
Contributor

Vogtinator commented Jul 11, 2018

This adds file operations to the dolphin test.

assert_and_click 'dolphin_stuff_empty', 'right';
my $create_new = assert_screen 'dolphin_create_new';

my $lastarea = $create_new->{area}->[-1];

This comment has been minimized.

@kravciak

kravciak Jul 12, 2018

Contributor

You can use xy function from lib/caasp_controller.pm for getting coordinates

This comment has been minimized.

@Vogtinator

Vogtinator Jul 12, 2018

Contributor

Why is that in caasp_controller? If it were somewhere more fitting I would use it...

This comment has been minimized.

@asmorodskyi

asmorodskyi Jul 12, 2018

Member

you may suggest PR which move this function to utils.pm :)

This comment has been minimized.

@Vogtinator

Vogtinator Jul 12, 2018

Contributor

A new parameter "hide_mouse" to assert_and_click probably makes more sense

my $x = int($lastarea->{x} + $lastarea->{w} / 2);
my $y = int($lastarea->{y} + $lastarea->{h} / 2);
mouse_set($x, $y);
mouse_click();

This comment has been minimized.

@asmorodskyi

asmorodskyi Jul 12, 2018

Member

awesome :)

@asmorodskyi asmorodskyi merged commit 6e24fb3 into os-autoinst:master Jul 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@okurz

This comment has been minimized.

Copy link
Member

okurz commented Jul 12, 2018


# Verify that it's visible in the file picker
x11_start_program('kdialog --getopenfilename', valid => 0);
assert_screen 'kdialog_places_stuff';

This comment has been minimized.

@okurz

okurz Jul 12, 2018

Member

I think you could use instead of these two lines the following

x11_start_program('kdialog --getopenfilename', target_match => 'kdialog_places_stuff');

this should speed up execution as well

@andreasstieger

This comment has been minimized.

@andreasstieger

This comment has been minimized.

@Vogtinator

This comment has been minimized.

Copy link
Contributor

Vogtinator commented Jul 13, 2018

Leap 42.3 and 15.0 maintenance testes remain broken. What's the deal @Vogtinator ?

Just missing needles - TW has previews turned on by default, which unfortunately means that none of the (many) needles were reusable for 15.0 and 42.3 appears to have slightly different font rendering.

Creating needles in a live instance is a bit cumbersome (it'll get worse once the interactive mode gets removed as part of the next deployment!) so it takes a full test run per needle...

I'll watch out for new failures.

@czerw

This comment has been minimized.

Copy link
Contributor

czerw commented Jul 14, 2018

@andreasstieger well, I noticed openSUSE failing tests, restart by @Vogtinator in audit log and new needle each restart. So it was obvious that work is in progress, which is great. But on other side, it makes review confusing. It would be better to mark it with poo, update needles in private instance and create new PR for Leap needle update.

@okurz

This comment has been minimized.

Copy link
Member

okurz commented Jul 14, 2018

@czerw I guess the main reason is because the interactive mode was removed from current openQA so a local run is not faster to fix many needles.

@czerw

This comment has been minimized.

Copy link
Contributor

czerw commented Jul 16, 2018

@Vogtinator what is the status of needles for 42.3? There are still failures https://openqa.opensuse.org/tests/707288#step/dolphin/10. Thank you.

@Vogtinator

This comment has been minimized.

Copy link
Contributor

Vogtinator commented Jul 16, 2018

@czerw Waiting to be merged: os-autoinst/os-autoinst-needles-opensuse#398

It also needs #5395 to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment