Unschedule yast2_lan_restart_devices when Network Manager #5780
Conversation
lib/main_common.pm
Outdated
| @@ -1438,7 +1438,7 @@ sub load_extra_tests_desktop { | |||
| # well | |||
| if (check_var('DESKTOP', 'gnome')) { | |||
| loadtest 'x11/yast2_lan_restart'; | |||
| loadtest 'x11/yast2_lan_restart_devices'; | |||
| loadtest 'x11/yast2_lan_restart_devices' unless (is_opensuse && !is_leap('<=15.0')); | |||
There was a problem hiding this comment.
Hmm, seems that I miss something, but haven't you adjusted this test suite to work with network manager?
Also, multiple conditions with unless are not as readable as it's if version.
There was a problem hiding this comment.
This test was a time ago a big test and I split this scenario in two. In yast2_lan_restart we only check tabs as most of the thing are disabled. yast2_lan_restart_devices is testing some 'more advance' configuration, so the whole test does't make sense to schedule it.
Let me fix the condition, think is not so cumbersome, my mistake.
There was a problem hiding this comment.
Ah, I see. Good approach, thanks for the clarification!
jknphy
force-pushed
the
network_manager_minor_fix_schedule
branch
from
e09b7a6
to
af6499c
Compare
|
I missed TW in the condition: https://openqa.opensuse.org/tests/757373#step/yast2_lan_restart_devices/20 |
|
PR with the change: #5788 |
Missed my last commit in #5752 (probably I had some issues with rebase). This should unschedule the second part of the test as it doesn't make sense when Network Manager is default.