ctrl-l seems delicate for clear screen, replace with an explicit 'clear' #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 12, 2016
…command Replace all occurences of 'ctrl-l' to clear the screen in a console with 'clear\n' in form of the new helper function 'clear_console()' as 'ctrl-l' is not buffered in the keybuffer whereas 'clear\n' is executed after the previous command returns to the prompt. Alternative or complementary to os-autoinst#923 Related issue: https://progress.opensuse.org/issues/10138
|
see my take on this in #926 . doesn't work yet because I don't know where to put the helper function. We could also merge it afterwards but I think we also have to fix other explicit calls of 'ctrl-l' for the same reason. |
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 12, 2016
…command Replace all occurences of 'ctrl-l' to clear the screen in a console with 'clear\n' in form of the new helper function 'clear_console()' as 'ctrl-l' is not buffered in the keybuffer whereas 'clear\n' is executed after the previous command returns to the prompt. Alternative or complementary to os-autoinst#923 Related issue: https://progress.opensuse.org/issues/10138
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 12, 2016
This should fix some flaky tests depending on machine execution performance. Replace all occurences of 'ctrl-l' to clear the screen in a console with 'clear\n' in form of the new helper function 'clear_console()' as 'ctrl-l' is not buffered in the keybuffer whereas 'clear\n' is executed after the previous command returns to the prompt. Tested locally with "console-consoletest_setup" and following on x86_64. No test of "ha" or similar has been done. Alternative or complementary to os-autoinst#923 Related issue: https://progress.opensuse.org/issues/10138
|
I don't think we have time pressure on this issue, so let's do it right in #926 |
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 13, 2016
This should fix some flaky tests depending on machine execution performance. Replace all occurences of 'ctrl-l' to clear the screen in a console with 'clear\n' in form of the new helper function 'clear_console()' as 'ctrl-l' is not buffered in the keybuffer whereas 'clear\n' is executed after the previous command returns to the prompt. Tested locally with "console-consoletest_setup" and following on x86_64. No test of "ha" or similar has been done. Alternative or complementary to os-autoinst#923 Related issue: https://progress.opensuse.org/issues/10138
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 13, 2016
This should fix some flaky tests depending on machine execution performance. Replace all occurences of 'ctrl-l' to clear the screen in a console with 'clear\n' in form of the new helper function 'clear_console()' as 'ctrl-l' is not buffered in the keybuffer whereas 'clear\n' is executed after the previous command returns to the prompt. Tested locally with "console-consoletest_setup" and following on x86_64. No test of "ha" or similar has been done. Alternative or complementary to os-autoinst#923 Related issue: https://progress.opensuse.org/issues/10138
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 15, 2016
This should fix some flaky tests depending on machine execution performance. Replace all occurences of 'ctrl-l' to clear the screen in a console with 'clear\n' in form of the new helper function 'clear_console()' as 'ctrl-l' is not buffered in the keybuffer whereas 'clear\n' is executed after the previous command returns to the prompt. Tested locally with "console-consoletest_setup" and following on x86_64. No test of "ha" or similar has been done. Alternative or complementary to os-autoinst#923 Related issue: https://progress.opensuse.org/issues/10138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.