New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svirt: set NUMDISK if RAIDLEVEL is defined, Xen: switch from IDE to SCSI devices #879

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@mnowaksuse
Contributor

mnowaksuse commented Nov 13, 2017

No description provided.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage increased (+0.06%) to 54.932% when pulling d7e160a on mnowaksuse:RAIDLEVEL_defines_NUMDISKS_4 into 652ad68 on os-autoinst:master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.06%) to 54.932% when pulling d7e160a on mnowaksuse:RAIDLEVEL_defines_NUMDISKS_4 into 652ad68 on os-autoinst:master.

@okurz

LGTM

mnowaksuse added some commits Nov 13, 2017

Xen: Support multiple HDDs
To support RAID test on svirt, multiple-disk support needs to be added
to bootloaded_svirt. For this to work, we can't use IDE device, because
it seems that Xen devices are in presence of IDE device connected to IDE
controller - but we can't connect more than four devices to IDE
controller. So switching to CDROM to SCSI makes the rest of the disks to
attach to SCSI controller (SCSI limit is 64 devices).

Validation runs on Xen HVM:
* JeOS: http://assam.suse.cz/tests/1003
* CaaSP: http://assam.suse.cz/tests/1005
* SLE15 lvm+RAID1: http://assam.suse.cz/tests/993
@mnowaksuse

This comment has been minimized.

Show comment
Hide comment
@mnowaksuse

mnowaksuse Nov 16, 2017

Contributor

Fixed typo in commit title.

Contributor

mnowaksuse commented Nov 16, 2017

Fixed typo in commit title.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 16, 2017

Coverage Status

Coverage increased (+0.06%) to 54.932% when pulling 96d7472 on mnowaksuse:RAIDLEVEL_defines_NUMDISKS_4 into 652ad68 on os-autoinst:master.

coveralls commented Nov 16, 2017

Coverage Status

Coverage increased (+0.06%) to 54.932% when pulling 96d7472 on mnowaksuse:RAIDLEVEL_defines_NUMDISKS_4 into 652ad68 on os-autoinst:master.

@@ -37,7 +37,7 @@ sub do_start_vm {
my ($self) = @_;
my $vars = \%bmwqemu::vars;
$vars->{NUMDISKS} ||= 1;
$vars->{NUMDISKS} ||= defined($vars->{RAIDLEVEL}) ? 4 : 1;

This comment has been minimized.

@foursixnine

foursixnine Nov 16, 2017

Member

I was about to ask what would happen when RAIDLEVEL=0 since we have that for functional tests until I noticed that this is about the svirt backend :P and we have kind of the same in the qemu backend

@foursixnine

foursixnine Nov 16, 2017

Member

I was about to ask what would happen when RAIDLEVEL=0 since we have that for functional tests until I noticed that this is about the svirt backend :P and we have kind of the same in the qemu backend

@foursixnine foursixnine merged commit 61d8b40 into os-autoinst:master Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 54.932%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment