Adds test for Router Interface idempotence #176
Conversation
rbrady
force-pushed
the
router-interface-idempotence
branch
from
7328dd8
to
41bd287
Compare
rbrady
force-pushed
the
router-interface-idempotence
branch
from
41bd287
to
ca8e0e6
Compare
|
This latest push is just the progress so far. It's currently throwing openstack.exceptions.ConflictException when running through the import in the idempotence test. I'll address this exception in a change tomorrow. |
rbrady
force-pushed
the
router-interface-idempotence
branch
from
ca8e0e6
to
6b3ea19
Compare
|
The create_or_update method has been modified to handle the exception, but the test isn't likely checking the right data to ensure idempotency (it's looking at routers.updated_at) |
| conn.network.add_interface_to_router( | ||
| refs['device_id'], port_id=port['id']) | ||
| changed = True | ||
| except openstack.exceptions.ConflictException: |
There was a problem hiding this comment.
There shouldn't be any conflict exception here:
-
we're looking up the port by IPs, if it exists, we don't create it
-
we're looking if it's assigned to the router already, if yes, we don't try to assign it again
The method should be a no-op, something's not working. I think we should figure out what's being executed that shouldn't be executed, rather than catching the exception.
There was a problem hiding this comment.
The error message output is here: https://gist.github.com/rbrady/ff2b8f41cb3a6738599102478d900078
rbrady
force-pushed
the
router-interface-idempotence
branch
from
6b3ea19
to
6e9fb74
Compare
This patch adds a test to ensure router interface idempotence and updates the router interface resource class to handle the case when a router interface already exists when attempting to create an identical one. This patch also fixes a small bug in the router interface where it was using the "subnet_name" key where it should have been using a "subnet_id" key. This was causing the unintended behavior of never finding a matching port when checking for ports that may have already been created, so it always tried to create the port leading to conflicts.
rbrady
force-pushed
the
router-interface-idempotence
branch
from
6e9fb74
to
bd0c25c
Compare
|
closes #21 |
| @@ -151,7 +150,7 @@ def _refs_from_ser(self, conn): | |||
| for fixed_ip in params['fixed_ips_names']: | |||
| refs['fixed_ips'].append({ | |||
| 'ip_address': fixed_ip['ip_address'], | |||
| 'subnet_name': reference.subnet_id(conn, fixed_ip['subnet_name']), | |||
| 'subnet_id': reference.subnet_id(conn, fixed_ip['subnet_name']), | |||
There was a problem hiding this comment.
Damn :). Thanks for the fix.
This patch adds a test to ensure router interface idempotence.