ifcfg: remove dpdk member interfaces during purge #322
Conversation
karthiksundaravel
force-pushed
the
fix_dpdk_vf
branch
from
9f6d300 to
2c062c2
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/00db8483d0d34f4ea1ec972aad28a04d ✔️ tox-linters SUCCESS in 3m 20s |
os_net_config/impl_ifcfg.py
Outdated
| self.del_device["dpdk_port"].extend(pci_address) | ||
|
|
||
| for dpdk_port in ovs_dpdk_bond.members: | ||
| ifname = dpdk_port.members[0].name |
There was a problem hiding this comment.
Do we need to check if members is not None here before accessing (however that would be wrong config)
karthiksundaravel
force-pushed
the
fix_dpdk_vf
branch
from
2c062c2 to
12dd074
Compare
| pci_address = self._get_dpdk_pci_addresses(ifcfg_dpdk) | ||
| self.del_device["dpdk_port"].extend(pci_address) | ||
|
|
||
| ifname = ovs_dpdk_port.members[0].name |
There was a problem hiding this comment.
Can we add check "if common.is_mellanox_interface()" ?
There was a problem hiding this comment.
I think it is not required. If the interface exists, it will be removed, if not it will proceed. Let us check in non mellanox cards as well
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4c8a7888d3334c62b4ab28e7c792b7d9 ✔️ tox-linters SUCCESS in 2m 44s |
karthiksundaravel
force-pushed
the
fix_dpdk_vf
branch
from
12dd074 to
5631c58
Compare
In case of Mellanox nics, the DPDK port members also have a ifcfg file and the same needs to be removed during purge provider. The dpdk port members could be one of interface or sriov_vf. Signed-off-by: Karthik Sundaravel <ksundara@redhat.com>
karthiksundaravel
force-pushed
the
fix_dpdk_vf
branch
from
5631c58 to
5f16573
Compare
3 participants
In case of Mellanox nics, the DPDK port members also have a ifcfg file and the same needs to be removed during purge provider. The dpdk port members could be one of interface or sriov_vf.