Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CAS authentication #31

Merged
merged 5 commits into from Jul 30, 2015

Conversation

@kevinoconnor7
Copy link
Contributor

@kevinoconnor7 kevinoconnor7 commented May 28, 2014

I have added support for Jasig CAS as an auth provider. CAS is popular at higher education institutions.

Implementation is kind-of similar to the oauth provider.

@wrighrc
Copy link

@wrighrc wrighrc commented Mar 4, 2015

Any idea if this pull request will be merged? We are interested in CAS with osTicket.

@kevinoconnor7
Copy link
Contributor Author

@kevinoconnor7 kevinoconnor7 commented Mar 4, 2015

Considering how long this PR has been out, I'm doubtful. I also haven't really tested it lately, but I haven't heard any issues of it failing in the one place I deployed it. Feel free to clone the repo, switch to my branch, compile my plugin and install it yourself. Let me know if you need help with that.

@jjsipahigil
Copy link

@jjsipahigil jjsipahigil commented Mar 24, 2015

I would also like to voice my support for merging this back in—you're definitely right about CAS and higher ed.

  - Providing no CA file path implies no verification will be used
  - An absolute path to a CA cert can no be provided
  - Resolved a bug with case-sensitive loading from PHAR
@kevinoconnor7 kevinoconnor7 force-pushed the kevinoconnor7:add-auth-cas branch from fcc67cd to 75743dc Mar 29, 2015
@kevinoconnor7
Copy link
Contributor Author

@kevinoconnor7 kevinoconnor7 commented Mar 30, 2015

I just did a small update to the PR. In addition, since people are interested in this I have written a blog post detailing how to install it in the meantime.

@kevinoconnor7
Copy link
Contributor Author

@kevinoconnor7 kevinoconnor7 commented Jun 4, 2015

I have added support for i18n, however I don't suspect that this PR is ever going to be merged in. As such I'm going to close this PR and put my plugin into its own repository. Further updates will be found there.

@greezybacon
Copy link
Contributor

@greezybacon greezybacon commented Jul 30, 2015

@kevinoconnor7 one of the issues I've yet to figure is dealing with fixes to the plugin. I suppose we should get going merging in others' plugins and figure that part out later. I'm happy to see your associated repo. I'd like to consider merging it here, but connecting to it via a Git submodule may be a better idea in the future.

@greezybacon greezybacon reopened this Jul 30, 2015
greezybacon added a commit that referenced this pull request Jul 30, 2015
Add support for CAS authentication

Reviewed-By: Jared Hancock <jared@osticket.com>
@greezybacon greezybacon merged commit ee4377b into osTicket:develop Jul 30, 2015
@kevinoconnor7
Copy link
Contributor Author

@kevinoconnor7 kevinoconnor7 commented Jul 30, 2015

I'm not sure merging this in at this point is the best idea. This branch is now behind the new repo. I can follow up with another PR to bring it up to date tonight if you wish. Though I think this might become burdensome if more plugins get merged in here and things start to diverge.

If you want to pursue a more accessible plugin system then it might be worth making a repository that contains a registry of approved plugins and their associated repos. You could probably hook it up to travis so you can build them, sign them, and host them on bintray or something. Then build out a small utility for osTicket that will fetch them and drop the signed phars into the plugin folder. Ideally I would then only need to bump a version number in this registry when I do a new release.

@kevinoconnor7
Copy link
Contributor Author

@kevinoconnor7 kevinoconnor7 commented Jul 30, 2015

Woops, look like you merged. I'll follow up later tonight to bring things up to date.

@greezybacon
Copy link
Contributor

@greezybacon greezybacon commented Jul 31, 2015

No worries. I can merge a branch from your repo. Which one?

Cheers,
Jared

Am Donnerstag, 30. Juli 2015 schrieb kevinoconnor7 :

Woops, look like you merged. I'll follow up later tonight to bring things
up to date.


Reply to this email directly or view it on GitHub
#31 (comment).

@kevinoconnor7
Copy link
Contributor Author

@kevinoconnor7 kevinoconnor7 commented Jul 31, 2015

Merge in at tag v1.0, which I believe is current HEAD and where the master
branch is. It's a bit tricky though because I have other files in there as
well (ex. my tavis CI config) so just make sure you grab only the auth_cas
folder.

On Thu, Jul 30, 2015 at 8:19 PM Jared Hancock notifications@github.com
wrote:

No worries. I can merge a branch from your repo. Which one?

Cheers,
Jared

Am Donnerstag, 30. Juli 2015 schrieb kevinoconnor7 :

Woops, look like you merged. I'll follow up later tonight to bring things
up to date.


Reply to this email directly or view it on GitHub
<#31 (comment)
.


Reply to this email directly or view it on GitHub
#31 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants