Skip to content
Permalink
Browse files

issue: Queue Sort Title No Validation Error

This addresses an issue reported on the Forum where adding a new Sort Option
for Queues without a title fails without error. This is due to the
queue-sorting template that uses a new instance of the
`QueueSortDataConfigForm` form from a new instance of `QueueSort` rather
than the existing form with existing POST data/errors when a POST is
submitted. This updates the queue-sorting template to use the already
available `$data_form` form instance. This also adds an if statement to set
the `$data_form` if one doesn’t exist (this only applies to new modals
without a POST).
  • Loading branch information...
JediKev committed Apr 29, 2019
1 parent dbc39b4 commit 029b0f2815e301b1d9ada6dc7352aa9dbe0e078f
Showing with 4 additions and 1 deletion.
  1. +3 −0 include/ajax.admin.php
  2. +1 −1 include/staff/templates/queue-sorting.tmpl.php
@@ -237,6 +237,9 @@ function addQueueSort($root='Ticket') {
}
}
if (!$data_form)
$data_form = $sort->getDataConfigForm();
include STAFFINC_DIR . 'templates/queue-sorting-add.tmpl.php';
}
@@ -1,4 +1,4 @@
<?php echo $sort->getDataConfigForm()->asTable(); ?>
<?php echo $data_form->asTable(); ?>

<table class="table">
<tbody class="sortable-rows">

0 comments on commit 029b0f2

Please sign in to comment.
You can’t perform that action at this time.