Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Code Optimization
We can log some edits in class.orm.php during the save function when this->dirty is generated rather than having to log them all within their classes.
- Loading branch information
Showing
with
5 additions
and 50 deletions.
- +0 −10 include/class.email.php
- +0 −7 include/class.filter.php
- +4 −0 include/class.orm.php
- +0 −7 include/class.page.php
- +0 −6 include/class.role.php
- +0 −16 include/class.staff.php
- +0 −3 include/class.topic.php
- +1 −1 scp/filters.php
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -389,16 +389,6 @@ function update($vars, &$errors=false) { | ||
|
||
if($errors) return false; | ||
|
||
$this->mail_errors = 0; | ||
$this->mail_lastfetch = null; | ||
$this->email = $vars['email']; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -360,13 +360,6 @@ function update($vars,&$errors) { | ||
$vars['target'] = 'Email'; | ||
} | ||
|
||
//Note: this will be set when validating filters | ||
if ($vars['email_id']) | ||
$emailId = $vars['email_id']; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -167,12 +167,6 @@ function update($vars, &$errors) { | ||
if ($errors) | ||
return false; | ||
|
||
$this->name = $vars['name']; | ||
$this->notes = $vars['notes']; | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -105,7 +105,7 @@ | ||
case 'delete': | ||
$i=0; | ||
foreach($_POST['ids'] as $k=>$v) { | ||
if(($f=Filter::lookup($v)) && !$f->isSystemBanlist() && $f->delete()) | ||
$i++; | ||
} | ||
|
||