Permalink
Commits on May 15, 2018
  1. queryset: Fix circular reference error

    greezybacon authored and protich committed Apr 19, 2018
    This fixes an error where the ModelInstanceManager maintained a reference to
    the QuerySet instance, and the QuerySet instance managed a reference to the
    ModelInstanceManager instance (if it's the iterator for the query). Because
    of the circular reference, if the iterator is not exhausted, then the
    resource is not closed and the query remains open. This wastes memory and
    prevents some other queries from running after such a situation happens.
    
    This addresses the issue by removing the circular reference between the
    QuerySet and the ModelInstanceManager.
Commits on Apr 19, 2018
  1. queryset: Fix circular reference error

    greezybacon committed Apr 19, 2018
    This fixes an error where the ModelInstanceManager maintained a reference to
    the QuerySet instance, and the QuerySet instance managed a reference to the
    ModelInstanceManager instance (if it's the iterator for the query). Because
    of the circular reference, if the iterator is not exhausted, then the
    resource is not closed and the query remains open. This wastes memory and
    prevents some other queries from running after such a situation happens.
    
    This addresses the issue by removing the circular reference between the
    QuerySet and the ModelInstanceManager.
Commits on Apr 10, 2017
  1. thread: Fix crash editing thread entry with inline image

    greezybacon committed Apr 10, 2017
    This fixes an InconsistentModelException error when editing thread
    entries with inline images. The fix assumes that inline images are
    re-attached when a new ThreadEntry is created and the body is copied
    from the previous entry. Only the non-inline attachments need to be
    moved in the update query.
Commits on Jul 14, 2016
  1. thread: Fix crash processing problem attachments

    greezybacon committed Jul 14, 2016
    The ThreadEntry::normalizeFileInfo() method is called from ::create(), but
    before the thread entry is saved. Therefore, the ::getThread() and
    ::getObject() methods will likely not return a valid object for posting the
    thread message.
Commits on Jul 8, 2016
Commits on Jun 25, 2016
  1. dept: Cleanup usage of ::getMembers()

    greezybacon committed Jun 25, 2016
    In ::isMember(), there is now no reason that a call to ::getMembers() would
    fail, so it can be assumed that a QuerySet instance is returned.
  2. orm: Fix warning for read-only permission

    greezybacon committed Jun 25, 2016
    This fixes an issue where the `$ht` variable is not properly initialized by
    the ORM. It is assumed to be a valid array in the constructor, and its items
    are run through the ::set() method. Therefore, if an empty array is
    received, the `$ht` variable will remain null, since nothing is ever set.
    
    This also fixes a misspelled variable in the claim dialog if a ticket is
    currently assigned to a team only.
  3. lists: Fix update of ticket status name

    greezybacon committed Jun 25, 2016
    Maybe fixes #3084
Commits on Jun 21, 2016
  1. dates: MySQL 'GMT' includes BST

    greezybacon committed Jun 21, 2016
    The PHP 'GMT' timezone is equivalent to the 'UTC' timezone and therefore
    does not include summertime offsets. The 'GMT' timezone reported by MySQL,
    however, does use the BST summertime offsets. Therefore, the 'GMT' reported
    by MySQL should be explicitly translated to the 'UTC' timezone for use in
    PHP.
Commits on Jun 20, 2016
  1. oops: Add missing echo

    greezybacon committed Jun 20, 2016
    Fixes #3194
  2. html: Fix processing of some <html> tags in email

    greezybacon committed Jun 20, 2016
    thanks @robintoy, @talilon
    
    This patch removes any contents of an html element when scrubbing html
    markup. Some markup includes complex namespaces and other information which
    does not concern the html processing of osTicket. It also messes up the
    htmLawed processing of the htmLawed.
    
    Maybe fixes #2465
    Maybe fixes #2272
Commits on Jun 12, 2016
Commits on Jun 11, 2016
  1. files: Drop parallel uploads

    greezybacon committed Jun 11, 2016
    This fixes files disappearing when uploading multiple files. Only one file
    at a time is uploaded to the server.
  2. Merge pull request #3153 from protich/feature/list-item-preview

    greezybacon committed Jun 11, 2016
    List Item Preview
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
Commits on Jun 2, 2016
  1. i18n: Ensure UTF-8 locale is set

    greezybacon committed Jun 2, 2016
    This is required for system requests such as email piping. Since a user is
    not logged in for the request, the system locale will not be set and text
    might get corrupted based on the PHP configuration.
    
    Fixes #2910
Commits on Apr 28, 2016
  1. cli: deploy: Automatically deploy rewritten files

    greezybacon committed Apr 28, 2016
    With the advent of the MANIFEST file, files which are rewritten when
    deployed, such as those which have the GIT hash in the query string to force
    browser reloading, were no longer deployed unless the content of those files
    changed.
    
    This patch adds a flag to the MANIFEST file to indicate that the file was
    rewritten when it was deployed. This allows the file to be deployed and
    rewritten again when the deployment is run, but also adds an indication
    to the console output to distinguish deploying changes as opposed to
    deploying rewrites.
Commits on Apr 26, 2016
  1. email: Regression for commit #3075 Rev

    greezybacon committed Apr 26, 2016
    email:  Regression for commit #3075 
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
Commits on Apr 25, 2016
Commits on Apr 24, 2016
  1. Merge pull request #3071 from protich/issue/upgrader+email_info

    greezybacon committed Apr 24, 2016
    upgrader: Split change and drop into 2 statements
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  2. files: Require authentication to view attachments

    greezybacon committed Mar 31, 2016
    This feature adds a setting to the control panel to require signing in to
    view attachments. This is in addition to the security already provided in
    the download URLs. Currently, download URLs are signed for a specific help
    desk, and automatically expire after about 24 hours. The exact timing is the
    following midnight allowing for at least 12 hours cache time.
    
    Administrators can impose this extra security feature to refuse serving
    attachment files if the user is not currently signed in. This could prevent
    third-party users from viewing an attachment if they were able to get access
    to the download URL before it expired.
  3. Merge pull request #3004 from protich/feature/deptaccess

    greezybacon committed Apr 24, 2016
    Department  Access and Membership
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  4. Merge pull request #2988 from protich/issue/dbsession

    greezybacon committed Apr 24, 2016
    Session: Create SessionData object on demand
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  5. Update class.auth.phpReviewed-By:

    greezybacon committed Apr 24, 2016
    Update class.auth.php
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  6. Merge pull request #3020 from protich/issue/closed-by

    greezybacon committed Apr 24, 2016
    closed-by: Credit the agent opening a ticket on close
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  7. Merge pull request #3068 from protich/feature/email-alias

    greezybacon committed Apr 24, 2016
    Email aliases
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  8. Merge pull request #3069 from protich/issue/files

    greezybacon committed Apr 24, 2016
    files: FileUploadWidget render
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  9. Merge pull request #3067 from protich/issue/orm-slot

    greezybacon committed Apr 24, 2016
    orm: Remove references to the retired slot feature
    
    Reviewed-By: Jared Hancock <jared@osticket.com>
  10. Merge pull request #3062 from protich/issue/org-delete

    greezybacon committed Apr 24, 2016
    org: Remove users from deleted org.
    
    Reviewed-By: Jared Hancock <jared@osticket.com>