New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10 Agent welcome email selection is missing #2870

Open
troycarpenter opened this Issue Jan 18, 2016 · 4 comments

Comments

Projects
None yet
5 participants
@troycarpenter

troycarpenter commented Jan 18, 2016

In 1.9.12, when adding a new agent there is a checkbox that allows sending the agent welcome email when creating the agent account. That selection seems to be missing in 1.10. If it moved to another screen, I can't find it.

@troycarpenter

This comment has been minimized.

Show comment
Hide comment
@troycarpenter

troycarpenter Jan 18, 2016

To make this work, I added the following in include/staff/staff.inc.php at line 175:

<?php if ($action=='create') { ?>
    <label class="checkbox">
        <input type="checkbox" name="welcome_email" id="welcome-email" checked="checked"/>
        <?php echo __('Send Welcome Email'); ?>
    </label>
<?php } ?>

It appears the backend code still understands how to send the email. The first line assures the checkbox only shows up when adding an agent. Also, this assumes you want to send the welcome emails by default as it automatically checks the box.

troycarpenter commented Jan 18, 2016

To make this work, I added the following in include/staff/staff.inc.php at line 175:

<?php if ($action=='create') { ?>
    <label class="checkbox">
        <input type="checkbox" name="welcome_email" id="welcome-email" checked="checked"/>
        <?php echo __('Send Welcome Email'); ?>
    </label>
<?php } ?>

It appears the backend code still understands how to send the email. The first line assures the checkbox only shows up when adding an agent. Also, this assumes you want to send the welcome emails by default as it automatically checks the box.

@xdreamarun

This comment has been minimized.

Show comment
Hide comment
@xdreamarun

xdreamarun Jan 6, 2017

we have added same code at same place.
we are using osticket version 1.10
Fields is displaying while create the agent.
But no email is going to agent.

xdreamarun commented Jan 6, 2017

we have added same code at same place.
we are using osticket version 1.10
Fields is displaying while create the agent.
But no email is going to agent.

@luismariveros

This comment has been minimized.

Show comment
Hide comment
@luismariveros

luismariveros May 31, 2017

I just installed osTicket Version v1.10 (901e5ea) and have the same problem... With the code of @troycarpenter it worked... I added at line 195

luismariveros commented May 31, 2017

I just installed osTicket Version v1.10 (901e5ea) and have the same problem... With the code of @troycarpenter it worked... I added at line 195

@lzantal

This comment has been minimized.

Show comment
Hide comment
@lzantal

lzantal Sep 8, 2017

Thanks for the code @troycarpenter. This fixed my installation as well. New user to osTicket so I didn't know where to start to enable it. Whats weird is that it sent it out twice before but then it suddenly stopped. Thanks again.

lzantal commented Sep 8, 2017

Thanks for the code @troycarpenter. This fixed my installation as well. New user to osTicket so I didn't know where to start to enable it. Whats weird is that it sent it out twice before but then it suddenly stopped. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment