fast fix for deployment on windows #2032 #2033

Merged
merged 2 commits into from May 13, 2015

Projects

None yet

4 participants

@yadimon
Contributor
yadimon commented May 8, 2015

Fixes #2032

@yakatz yakatz commented on an outdated diff May 8, 2015
setup/cli/modules/deploy.php
@@ -151,11 +151,12 @@ function run($args, $options) {
# Locate the upload folder
$root = $this->find_root_folder();
+ $rootPattern = str_replace("\\","\\\\", $this->find_root_folder()); //need for windows case
@yakatz
yakatz May 8, 2015 Contributor

How about $rootPattern = str_replace("\\","\\\\", $root); so you don't need to call the find function again?

@greezybacon
Member

Can anyone confirm this fixes deployment issues on Windows?

@mfelber
mfelber commented May 11, 2015

@greezybacon Yes, I can confirm that this fix changes the behavior as expected. The .git and setup-folder will not be deployed anymore when you use the deploy script without the --setup parameter.

@greezybacon greezybacon merged commit 82bcda9 into osTicket:develop May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment