New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: Balancing is important #2145

Merged
merged 1 commit into from Jun 8, 2015

Conversation

Projects
None yet
2 participants
@greezybacon
Member

greezybacon commented Jun 8, 2015

9ae01bf turned off HTML balancing, however, quoted response removal will create unbalanced HTML. That HTML will be stored unbalanced and will require extra processing when displayed on the ticket thread.

This patch adds balancing support using libxml if enabled, which will balance HTML without corrupting the HTML like htmLawed will with balancing enabled.

Show outdated Hide outdated include/class.format.php Outdated
html: Balancing is important
9ae01bf turned off HTML balancing, however,
quoted response removal will create unbalanced HTML. That HTML will be
stored unbalanced and will require extra processing when displayed on the
ticket thread.

This patch adds balancing support using libxml if enabled, which will
balance HTML without corrupting the HTML like htmLawed will with balancing
enabled.

protich added a commit that referenced this pull request Jun 8, 2015

Merge pull request #2145 from greezybacon/feature/libxml-balance
html: Balancing is important

Reviewed-By: Peter Rotich <peter@osticket.com>

@protich protich merged commit f070fe1 into osTicket:develop Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment