New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Customizable ticket queues, customizable columns #2577

Closed
wants to merge 113 commits into
base: develop
from

Conversation

Projects
None yet
@greezybacon
Member

greezybacon commented Sep 21, 2015

How-To Test

Checkout this branch (greezybacon/feature/custom-queues) or visit my page and download the ZIP file.

Visit the setup page and perform a normal installation. You can also attempt an upgrade from any version v1.6ST and forward. Happy testing.

Screenshot Tour

Ticket queues are defined in Settings -> Tickets page, "Queues" tab

screen shot 2015-10-07 at 10 22 21 pm

Queues inherit the criteria system from the Advanced Search feature, but have the addition of a "Name" and "Description" (todo)

Queues also have the ability to inherit criteria from a parent queue. Therefore, queues defined under "Open" would not need to include criteria to define "Open" tickets again and again

screen shot 2016-06-05 at 2 01 40 pm

Queues have designable columns

Any data associated with just about anything can be listed in the ticket queue page. Primary and secondary data sources are selectable. If no data exists for the primary data field, then the data from the secondary is displayed in the queue listing. Columns can be dragged to arrange their order.

screen shot 2016-06-05 at 1 42 59 pm

Columns can have annotations

Annotations are extra flair, such as the attachment count, collaborator count, overdue flag, etc., which can be added to the start or end of the cell (floating), or before or after the text (inline).

screen shot 2016-06-05 at 1 54 58 pm

Columns can have sophisticated conditions

Conditions are checks run on the data associated with the ticket. For records that match the conditions, extra formatting can be defined. For instance, unanswered tickets can have some cells shown in bold. Any data (custom or otherwise) affiliated with the ticket, user, and organization, can be used in conditions. Even set crazy things like background-color

screen shot 2016-06-05 at 1 44 45 pm

Preview before saving

All settings for the criteria, column sources, annotations, conditions, etc., are viewable without saving. Click the "Preview" tab and the queue is rendered dynamically.

screen shot 2015-10-07 at 10 24 33 pm

Queue pages have hierarchical navigation

Queues are selectable from drop-down navigation in the ticket listing pages. Additionally, edit or delete the queue straight from the navigation.

screen shot 2016-06-05 at 1 42 35 pm

Use "Quick Filter" to reduce ticket listing in real-time

Choose field such as Assignee, Department, Help Topic, some custom data field, etc., which can be selected when the queue is viewed. The queue will be filtered to only show tickets matching the quick filter.

screen shot 2015-10-07 at 10 25 35 pm

Columns are customizable for (saved) advanced searches too

screen shot 2016-06-05 at 1 48 40 pm

Quick access to edit queues, as well as add and remove custom personal sub-queues

screen shot 2016-06-05 at 1 42 45 pm

Queue column headings are translatable

screen shot 2016-06-05 at 1 45 37 pm

Outstanding

  • Add screenshots
  • Add how-to guide for testing
  • Make column headings translatable
  • Drop interactive column resizing
  • Add core settings for default queue (previously "Open")
  • Add container queues with no criteria and default sub-queues. This will replace the current "Show assigned tickets on open queue" setting and friends. When the container queue is clicked, the default sub-queue will be shown instead
  • Implement quick filter
  • Implement sorting options
  • Add install yaml for queues previous to v1.11
  • Implement column delete from queue
  • Enable/disable queues
  • Add description (queue page title) field
  • Delete queue
  • Select column configuration for rendering saved search
  • Publish (make public) feature for saved searches
  • Add personal queues
  • Add queue counts or drop the (?) tokens, rectify staff stats functions
  • Add navigation for saved searches
  • Add queue as a child (via navigation)
  • Conditions do not load properly when editing a queue
  • Implement sorting options, sortable headers
  • Implement staff visibility constraints
  • Integrate advanced search and saved searches
  • path is not set correct at installation
  • Integrate user and org searches from ticket view
  • Transition advanced search criteria to the new object-base getSearchableFields used for queues
  • Add recent search history to search dropdown
  • Queue management does not work in Firefox
  • Show parent queue criteria, grayed out (disabled) for personal queues
  • Add custom columns to saved searches
  • Add icon selection to custom queue management page
  • Add date formatting options in somewhere (maybe in the filter?)
  • Retire CDATA usage and feature
  • Add advanced sorting options
  • Add default advanced sort to queue configuration
  • Delete custom column (definition)
  • Delete custom sort criteria (definition)
  • Personal queue columns don't need to be translatable
  • Add conditions to the queue itself, allowing for controlling the display of an entire row
  • Make queue titles translatable
Show outdated Hide outdated include/class.orm.php Outdated
@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Sep 22, 2015

Contributor

Add screenshots

Definitely! ;)

Contributor

Chefkeks commented Sep 22, 2015

Add screenshots

Definitely! ;)

@jdelhome3578

This comment has been minimized.

Show comment
Hide comment
@jdelhome3578

jdelhome3578 Sep 28, 2015

Contributor

👍 💯 I would love to see this in 1.10

Contributor

jdelhome3578 commented Sep 28, 2015

👍 💯 I would love to see this in 1.10

@balojs

This comment has been minimized.

Show comment
Hide comment
@balojs

balojs commented Sep 28, 2015

+1

@jdelhome3578 jdelhome3578 referenced this pull request Oct 1, 2015

Closed

Pending Ticket Auto Close 1.9.x #2152

0 of 2 tasks complete
@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 8, 2015

Member

Aight peeps. I've added some screenshots. I hope to near an alpha state tomorrow and will add some notes on how to test the feature.

Cheers

Member

greezybacon commented Oct 8, 2015

Aight peeps. I've added some screenshots. I hope to near an alpha state tomorrow and will add some notes on how to test the feature.

Cheers

@AlexYoung28

This comment has been minimized.

Show comment
Hide comment
@AlexYoung28

AlexYoung28 Oct 8, 2015

Looks really good!!

AlexYoung28 commented Oct 8, 2015

Looks really good!!

@Aka4Code

This comment has been minimized.

Show comment
Hide comment
@Aka4Code

Aka4Code Oct 8, 2015

Amazing :) You plan to release this feature in 1.10 RC3?

Aka4Code commented Oct 8, 2015

Amazing :) You plan to release this feature in 1.10 RC3?

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 8, 2015

Contributor

Looks pretty good 👍 and I know it's far from being finished, but anyway some minor suggestion from my side.
Did some quick edits in MS Paint to show you what I mean - not pretty but a picture often says more than a thousand words:

I'd remove the sub menu to edit/delete a queue and display the button directly inline (maybe with a tooltip when mouse is over the button)

image

Additionally I'd really love to see an option to display all or several (select-able) queues in one page:

image

The queue page itself should then look like the following if several/all queues are selected:

image

Contributor

Chefkeks commented Oct 8, 2015

Looks pretty good 👍 and I know it's far from being finished, but anyway some minor suggestion from my side.
Did some quick edits in MS Paint to show you what I mean - not pretty but a picture often says more than a thousand words:

I'd remove the sub menu to edit/delete a queue and display the button directly inline (maybe with a tooltip when mouse is over the button)

image

Additionally I'd really love to see an option to display all or several (select-able) queues in one page:

image

The queue page itself should then look like the following if several/all queues are selected:

image

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 8, 2015

Member

Additionally I'd really love to see an option to display all or several (select-able) queues in one page:

Could you expand on this idea? Bear in mind that the feature will allow you to create as many queues as you want and specify the criteria for each.

If showing more than one, would the results be a union or an intersection (unique results from both queues or results common in both queues respectively). How would the column display differences be rectified between multiple queues?

Member

greezybacon commented Oct 8, 2015

Additionally I'd really love to see an option to display all or several (select-able) queues in one page:

Could you expand on this idea? Bear in mind that the feature will allow you to create as many queues as you want and specify the criteria for each.

If showing more than one, would the results be a union or an intersection (unique results from both queues or results common in both queues respectively). How would the column display differences be rectified between multiple queues?

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 8, 2015

Member

@aka4 sorry, this is a major feature for the next major version

Member

greezybacon commented Oct 8, 2015

@aka4 sorry, this is a major feature for the next major version

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 8, 2015

Contributor

Could you expand on this idea? Bear in mind that the feature will allow you to create as many queues as you want and specify the criteria for each.

If showing more than one, would the results be a union or an intersection (unique results from both queues or results common in both queues respectively). How would the column display differences be rectified between multiple queues?

Hehe, I get your point and see what the issue it would cause... Have to admit that I didn't see this issue coming.

Basically I'd tend to show a ticket that for example is unassigned + unanswered in both queues (unassigned queue and unanswered queue) since it matches the corresponding criteria of each queue. Reason is that I personally think showing multiple queues should not affect the results of a queue - so just display them together. Even though some tickets will then be displayed in more than 1 queue.

Contributor

Chefkeks commented Oct 8, 2015

Could you expand on this idea? Bear in mind that the feature will allow you to create as many queues as you want and specify the criteria for each.

If showing more than one, would the results be a union or an intersection (unique results from both queues or results common in both queues respectively). How would the column display differences be rectified between multiple queues?

Hehe, I get your point and see what the issue it would cause... Have to admit that I didn't see this issue coming.

Basically I'd tend to show a ticket that for example is unassigned + unanswered in both queues (unassigned queue and unanswered queue) since it matches the corresponding criteria of each queue. Reason is that I personally think showing multiple queues should not affect the results of a queue - so just display them together. Even though some tickets will then be displayed in more than 1 queue.

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 8, 2015

Member

Yeah, I think I see your point: The criteria system doesn't allow for OR based criteria

Member

greezybacon commented Oct 8, 2015

Yeah, I think I see your point: The criteria system doesn't allow for OR based criteria

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 8, 2015

Member

As a workaround, you could flip the logic ((A or B) == !(A and B)). Therefore, one could create another queue (named "Unassigned + Unanswered") with the criteria Assignee: assigned and Answered: checked, then we could maybe just add another option to invert the criteria ([ ] Show records NOT matching these criteria)

Member

greezybacon commented Oct 8, 2015

As a workaround, you could flip the logic ((A or B) == !(A and B)). Therefore, one could create another queue (named "Unassigned + Unanswered") with the criteria Assignee: assigned and Answered: checked, then we could maybe just add another option to invert the criteria ([ ] Show records NOT matching these criteria)

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 9, 2015

Contributor

Yeah, I think I see your point: The criteria system doesn't allow for OR based criteria

Hadn't that in mind, but yes it's true the system doesn't allow for OR based criteria. So I guess either you think too complex or I'm thinking too simple ;)

Basically my thought / suggestion was to allow for multiple queues to be displayed, so you don't have to "click around" every time you want to see another (open/personal/closed/etc.) queue and can see all tickets that are open + some-other-condition on 1 page at a glance (grouped by queue).

Hope I could now better explain what my original intention was behind that suggestion.

Anyway, when I could give you or someone else from the osTicket team some inspirations for more possibilities or additional/better options regarding this coming feature I think all osTicket users will benefit which is surely a good thing (independent of you like or dis-like my suggestion(s)).

Contributor

Chefkeks commented Oct 9, 2015

Yeah, I think I see your point: The criteria system doesn't allow for OR based criteria

Hadn't that in mind, but yes it's true the system doesn't allow for OR based criteria. So I guess either you think too complex or I'm thinking too simple ;)

Basically my thought / suggestion was to allow for multiple queues to be displayed, so you don't have to "click around" every time you want to see another (open/personal/closed/etc.) queue and can see all tickets that are open + some-other-condition on 1 page at a glance (grouped by queue).

Hope I could now better explain what my original intention was behind that suggestion.

Anyway, when I could give you or someone else from the osTicket team some inspirations for more possibilities or additional/better options regarding this coming feature I think all osTicket users will benefit which is surely a good thing (independent of you like or dis-like my suggestion(s)).

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 13, 2015

Member

I've shored up the installer and added a How-To guide for installing this branch. Keep up the feedback!

Member

greezybacon commented Oct 13, 2015

I've shored up the installer and added a How-To guide for installing this branch. Keep up the feedback!

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 13, 2015

Contributor

Great!
Going to setup a test system as soon as possible... so hopefully tomorrow since I've some jobs left for the rest of this day :(

Contributor

Chefkeks commented Oct 13, 2015

Great!
Going to setup a test system as soon as possible... so hopefully tomorrow since I've some jobs left for the rest of this day :(

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 13, 2015

Contributor

OK, luckily did found some time, so have it running an testing.

Despite some SQL errors I sometimes get to see, everything looks pretty good, but sure got some more detailed feedback below. I know understand a lot better the relationship between queues and sub-queues / top-level queues and so I guess my suggestion from a few days ago doesn't seem to make sense anymore to myself :D

Randomly starting my feedback with this here:

I'd suggest to remove the width input field. The 3 vertical dots to change the size of a column is all it needs. As you can see I used a ridiculous width of 5000 and to my surprise it worked. I'd suggest to only allow 1 row for columns with a max-width value (which is similar to max-width used for queues) and don't allow re-sizing the columns any further, so don't allow for a second or third row for the columns. (Hope you understand what I mean).
image
In the case that all columns together are as wide as max-width and the user wants to add a new column, I'd suggest to reduce the width of the last column (since I guess a new column is appended after the last column) by 10(px / em / whatever it actually is) and insert the new column then with a width of 10. By the way - is there a min-width for columns?

Assuming the width input field is removed (but also if you want to keep it), currently I don't like the arrangement of the fields, so here's a suggestion how I'd arrange them:
image
The heading should be on top (since it's also on top of a column) and for the data in the column (which is then below the heading) display the options (data sources, filters, text overflow) below.

The conditions look a bit lost, my suggestion is to re-work the design, so it looks more like the advanced search - did another painting mod therefore - quick&dirty, but I guess you know then better what I mean:
image

What annoyed me a bit too was that a sub-queue didn't automatically had the column layout of the queue above, but after I thought a bit about it, I think it's good to not do so.

So far from my side for today - will add some more feedback tomorrow since I've now "Feierabend" ;) :D

PS: Really love the quick filter option!

Contributor

Chefkeks commented Oct 13, 2015

OK, luckily did found some time, so have it running an testing.

Despite some SQL errors I sometimes get to see, everything looks pretty good, but sure got some more detailed feedback below. I know understand a lot better the relationship between queues and sub-queues / top-level queues and so I guess my suggestion from a few days ago doesn't seem to make sense anymore to myself :D

Randomly starting my feedback with this here:

I'd suggest to remove the width input field. The 3 vertical dots to change the size of a column is all it needs. As you can see I used a ridiculous width of 5000 and to my surprise it worked. I'd suggest to only allow 1 row for columns with a max-width value (which is similar to max-width used for queues) and don't allow re-sizing the columns any further, so don't allow for a second or third row for the columns. (Hope you understand what I mean).
image
In the case that all columns together are as wide as max-width and the user wants to add a new column, I'd suggest to reduce the width of the last column (since I guess a new column is appended after the last column) by 10(px / em / whatever it actually is) and insert the new column then with a width of 10. By the way - is there a min-width for columns?

Assuming the width input field is removed (but also if you want to keep it), currently I don't like the arrangement of the fields, so here's a suggestion how I'd arrange them:
image
The heading should be on top (since it's also on top of a column) and for the data in the column (which is then below the heading) display the options (data sources, filters, text overflow) below.

The conditions look a bit lost, my suggestion is to re-work the design, so it looks more like the advanced search - did another painting mod therefore - quick&dirty, but I guess you know then better what I mean:
image

What annoyed me a bit too was that a sub-queue didn't automatically had the column layout of the queue above, but after I thought a bit about it, I think it's good to not do so.

So far from my side for today - will add some more feedback tomorrow since I've now "Feierabend" ;) :D

PS: Really love the quick filter option!

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 14, 2015

Contributor

I'd always make sure that at least 1 column is selected - so the user directly sees the options and disable that none can be selected when accessing the columns tab:
image

Contributor

Chefkeks commented Oct 14, 2015

I'd always make sure that at least 1 column is selected - so the user directly sees the options and disable that none can be selected when accessing the columns tab:
image

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 14, 2015

Contributor

Would be great if there were an option to change the order / sorting of the queue (like it's possible for help topics) somewhere here:
image

Custom queues feature summarized: 👍
I really like custom queues and the way they are implemented into osTicket - sure in some areas in my opinion it needs some little refinements, but overall it already look and feel pretty good (despite a lot SQL error, but I know it's far from being finished).

Btw. have to revert that feedback below since after playing with custom queues I think it's better to "hide" the edit and delete button in another sub-menu to avoid accidental clicks of these buttons.

I'd remove the sub menu to edit/delete a queue and display the button directly inline (maybe with a tooltip when mouse is over the button)
image

Cheers,
Michael

Contributor

Chefkeks commented Oct 14, 2015

Would be great if there were an option to change the order / sorting of the queue (like it's possible for help topics) somewhere here:
image

Custom queues feature summarized: 👍
I really like custom queues and the way they are implemented into osTicket - sure in some areas in my opinion it needs some little refinements, but overall it already look and feel pretty good (despite a lot SQL error, but I know it's far from being finished).

Btw. have to revert that feedback below since after playing with custom queues I think it's better to "hide" the edit and delete button in another sub-menu to avoid accidental clicks of these buttons.

I'd remove the sub menu to edit/delete a queue and display the button directly inline (maybe with a tooltip when mouse is over the button)
image

Cheers,
Michael

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 16, 2015

Member

You can click and drag to sort the queues

Member

greezybacon commented Oct 16, 2015

You can click and drag to sort the queues

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 16, 2015

Contributor

Hehe, ok definitely didn't try this since I did not see any hints / signs / symbols that it's possible to click and drag the queues.

Maybe it needs to be more obvious that you can click and drag to sort the queues.

Contributor

Chefkeks commented Oct 16, 2015

Hehe, ok definitely didn't try this since I did not see any hints / signs / symbols that it's possible to click and drag the queues.

Maybe it needs to be more obvious that you can click and drag to sort the queues.

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 16, 2015

Member

Maybe it needs to be more obvious that you can click and drag to sort the queues.

Fair enough. I realized that I forgot to include the install file for the queues, which probably is responsible for your significant quantity of SQL errors.

Member

greezybacon commented Oct 16, 2015

Maybe it needs to be more obvious that you can click and drag to sort the queues.

Fair enough. I realized that I forgot to include the install file for the queues, which probably is responsible for your significant quantity of SQL errors.

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Oct 17, 2015

Contributor

Just had another idea/thought while reading your response. Regarding options which allow inheritance, it would be nice if you'd show the settings which come from an inherit queue, but making them look read only / disabled so the user knows what settings are coming from an inherit queue.
If it's already implemented that way I must have missed it ;)

Contributor

Chefkeks commented Oct 17, 2015

Just had another idea/thought while reading your response. Regarding options which allow inheritance, it would be nice if you'd show the settings which come from an inherit queue, but making them look read only / disabled so the user knows what settings are coming from an inherit queue.
If it's already implemented that way I must have missed it ;)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 17, 2015

@greezybacon I have just downloaded the zip file from your site and followed the install instructions but some of the features that you are describing in your screenshot tour are missing in my test installation. For example the managing options of the queues in the "Columns"-tab:

columns

When I click on a column it won't get blue and nothing happens (also the configure options are missing).

The "My Tickets" queue is missing. Should it be there?

queues

I know the custom queue feature isn't completed but it looks like the managing options of the columns should be available in this "preview" (in the screenshots of chefkeks I see this options)..

ghost commented Oct 17, 2015

@greezybacon I have just downloaded the zip file from your site and followed the install instructions but some of the features that you are describing in your screenshot tour are missing in my test installation. For example the managing options of the queues in the "Columns"-tab:

columns

When I click on a column it won't get blue and nothing happens (also the configure options are missing).

The "My Tickets" queue is missing. Should it be there?

queues

I know the custom queue feature isn't completed but it looks like the managing options of the columns should be available in this "preview" (in the screenshots of chefkeks I see this options)..

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 17, 2015

Member

@mfelber I did notice that it doesn't seem to work in Firefox. Can you try another browser for your initial testing?

Member

greezybacon commented Oct 17, 2015

@mfelber I did notice that it doesn't seem to work in Firefox. Can you try another browser for your initial testing?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 17, 2015

@greezybacon Yes, thanks for the hint! With Safari and Chrome I can use the configure options in the "Columns" tab :-)

ghost commented Oct 17, 2015

@greezybacon Yes, thanks for the hint! With Safari and Chrome I can use the configure options in the "Columns" tab :-)

@Aka4Code

This comment has been minimized.

Show comment
Hide comment
@Aka4Code

Aka4Code Oct 19, 2015

@greezybacon
I like @Chefkeks idea about displaying several queues in one page.

Can you add option to define GROUP BY column?

For example I would like to group some queues by Department or Assignee, that way it could be really good thing, below is modified version of @Chefkeks idea mockup:

image

or the same mockup, but grouped by agents:
image

In such way, in each group will be no column display differences.

Aka4Code commented Oct 19, 2015

@greezybacon
I like @Chefkeks idea about displaying several queues in one page.

Can you add option to define GROUP BY column?

For example I would like to group some queues by Department or Assignee, that way it could be really good thing, below is modified version of @Chefkeks idea mockup:

image

or the same mockup, but grouped by agents:
image

In such way, in each group will be no column display differences.

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Oct 20, 2015

Member

@aka4 that's what the "quick filter" option is about. It allows you to filter the queue by another value such as the department or assignee

Member

greezybacon commented Oct 20, 2015

@aka4 that's what the "quick filter" option is about. It allows you to filter the queue by another value such as the department or assignee

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Feb 6, 2018

Contributor

@rhew90 So you are saying that:
You installed this PR on 1.10 and search works.
You installed this PR on 1.10.1 and search does not work.
This PR has never been updated for 1.10.1, and is intended for 1.10.
Did you try search in 1.10.1 prior to installing the PR?

Contributor

ntozier commented Feb 6, 2018

@rhew90 So you are saying that:
You installed this PR on 1.10 and search works.
You installed this PR on 1.10.1 and search does not work.
This PR has never been updated for 1.10.1, and is intended for 1.10.
Did you try search in 1.10.1 prior to installing the PR?

@rhew90

This comment has been minimized.

Show comment
Hide comment
@rhew90

rhew90 Feb 6, 2018

@ntozier I have not made any updates.

I have performed a clean installation with this. I have downloaded the complete Zip and in the information is written 1.8 Git. The search does not work.

So I deleted everything and installed the official stable version from site 1.10.1

rhew90 commented Feb 6, 2018

@ntozier I have not made any updates.

I have performed a clean installation with this. I have downloaded the complete Zip and in the information is written 1.8 Git. The search does not work.

So I deleted everything and installed the official stable version from site 1.10.1

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Feb 6, 2018

Contributor

Sorry, i have no idea what your saying... If you used this PR then you updated 83 files... and this PR still has nothing to do with search.

Contributor

ntozier commented Feb 6, 2018

Sorry, i have no idea what your saying... If you used this PR then you updated 83 files... and this PR still has nothing to do with search.

@rhew90

This comment has been minimized.

Show comment
Hide comment
@rhew90

rhew90 Feb 6, 2018

schermata 2018-02-06 alle 18 19 00

I downloaded the zip package and installed. Stop

rhew90 commented Feb 6, 2018

schermata 2018-02-06 alle 18 19 00

I downloaded the zip package and installed. Stop

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Feb 6, 2018

Contributor

@rhew90 so we are back to this.

You are saying that:
You installed this PR on 1.10 and search works.
You installed this PR on 1.10.1 and search does not work.
Did you try search in 1.10.1 prior to installing the PR?

Contributor

ntozier commented Feb 6, 2018

@rhew90 so we are back to this.

You are saying that:
You installed this PR on 1.10 and search works.
You installed this PR on 1.10.1 and search does not work.
Did you try search in 1.10.1 prior to installing the PR?

@rhew90

This comment has been minimized.

Show comment
Hide comment
@rhew90

rhew90 Feb 6, 2018

leave it

rhew90 commented Feb 6, 2018

leave it

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Feb 6, 2018

Contributor

Is there some reason why you cannot simply answer the question?

Contributor

ntozier commented Feb 6, 2018

Is there some reason why you cannot simply answer the question?

@rhew90

This comment has been minimized.

Show comment
Hide comment
@rhew90

rhew90 Feb 6, 2018

I downloaded the zip package and installed. Stop
Version 1.8-Git and search not function.

schermata 2018-02-06 alle 18 40 40

Now I have installed 1.10.1 from here http://osticket.com/download
without Customizable ticket queues.

I do not want to make the change anymore because for me it does not work.

ok?

rhew90 commented Feb 6, 2018

I downloaded the zip package and installed. Stop
Version 1.8-Git and search not function.

schermata 2018-02-06 alle 18 40 40

Now I have installed 1.10.1 from here http://osticket.com/download
without Customizable ticket queues.

I do not want to make the change anymore because for me it does not work.

ok?

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Feb 6, 2018

Contributor

Q: Did you try search in 1.10.1 prior to installing the PR?
Your Answer: no.

Contributor

ntozier commented Feb 6, 2018

Q: Did you try search in 1.10.1 prior to installing the PR?
Your Answer: no.

@Seaev

This comment has been minimized.

Show comment
Hide comment
@Seaev

Seaev Feb 27, 2018

Hello!
Do you know which files i have to integrate on OSTicket 1.10.1 to have your feature ?

Thanks a lot!

Seaev commented Feb 27, 2018

Hello!
Do you know which files i have to integrate on OSTicket 1.10.1 to have your feature ?

Thanks a lot!

@olly3gs

This comment has been minimized.

Show comment
Hide comment
@olly3gs

olly3gs Feb 27, 2018

olly3gs commented Feb 27, 2018

greezybacon added some commits Apr 19, 2018

queue: Improve queries necessary for rendering
This removes a significant number of queries used to render the drop-down
menu for the queues.

Each queue displayed on the page previously required a database query to
determine its children. This patch changes the strategy to fetch all the
queues and organize them as a tree. The tree can then be walked as the menu
is rendered and does not require any further queries.

On my test system, it reduces the number of queries for the ticket listing
page from 56 to 46.
@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Apr 29, 2018

Member

@rhew90 sorry for the long silence. I changed my system to Italian and attempted to recreate your crash and I cannot. Are you still able to available to comment on the issue?

Member

greezybacon commented Apr 29, 2018

@rhew90 sorry for the long silence. I changed my system to Italian and attempted to recreate your crash and I cannot. Are you still able to available to comment on the issue?

@mikshepard

This comment has been minimized.

Show comment
Hide comment
@mikshepard

mikshepard May 10, 2018

@greezybacon : I'm running into an issue, where I can't edit teams. Going into the Admin Panel --> Agents --> "Teams" tab and trying to select an existing team puts a grey overlay over the page. Here is the error log:

[Thu May 10 15:22:13.456973 2018] [:error] [pid 24191] [client X.X.X.X] PHP Warning: Invalid argument supplied for foreach() in /var/www/osticket/include/staff/team.inc.php on line 235, referer: https://ticket.mysite.org/scp/teams.php

I'm using a direct pull of your repo for this. Running Debian 8, with php 5.6.33, mysql 5.7.22

Are you able to recreate? Any idea of the issue?

Many thanks on this PR, it's been working great otherwise

mikshepard commented May 10, 2018

@greezybacon : I'm running into an issue, where I can't edit teams. Going into the Admin Panel --> Agents --> "Teams" tab and trying to select an existing team puts a grey overlay over the page. Here is the error log:

[Thu May 10 15:22:13.456973 2018] [:error] [pid 24191] [client X.X.X.X] PHP Warning: Invalid argument supplied for foreach() in /var/www/osticket/include/staff/team.inc.php on line 235, referer: https://ticket.mysite.org/scp/teams.php

I'm using a direct pull of your repo for this. Running Debian 8, with php 5.6.33, mysql 5.7.22

Are you able to recreate? Any idea of the issue?

Many thanks on this PR, it's been working great otherwise

@lewishackfath

This comment has been minimized.

Show comment
Hide comment
@lewishackfath

lewishackfath May 14, 2018

Is there anyway to roleback this code and install the latest version of OST without the custom queues?

lewishackfath commented May 14, 2018

Is there anyway to roleback this code and install the latest version of OST without the custom queues?

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier May 14, 2018

Contributor

Download the current version from osticket.com/download.

Contributor

ntozier commented May 14, 2018

Download the current version from osticket.com/download.

@lewishackfath

This comment has been minimized.

Show comment
Hide comment
@lewishackfath

lewishackfath May 14, 2018

@ntozier I just did that and get the following error message on the updater page:
The upgrader does NOT support upgrading from the current patch [ad9d0a5f1bd9f83a4ecb3f590b334eac]!

lewishackfath commented May 14, 2018

@ntozier I just did that and get the following error message on the updater page:
The upgrader does NOT support upgrading from the current patch [ad9d0a5f1bd9f83a4ecb3f590b334eac]!

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier May 14, 2018

Contributor

Then highly unlikely. If it made changes to the database you would have to find out what they were, and reverse them to go backwards.

Contributor

ntozier commented May 14, 2018

Then highly unlikely. If it made changes to the database you would have to find out what they were, and reverse them to go backwards.

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev May 14, 2018

Member

@lewishackfath

Because your DB still has the upgraded tables and new schema_signature in the ost_config table. Please revert the DB to the backup in order to restore the database to its original state. (you should've backed up the db and files before making these changes)

If you don't have a backup (which is bad news bears) you should compare your DB to the DB of a new installation of your version and restore the tables and schema_signature to its original state.

Cheers.

Member

JediKev commented May 14, 2018

@lewishackfath

Because your DB still has the upgraded tables and new schema_signature in the ost_config table. Please revert the DB to the backup in order to restore the database to its original state. (you should've backed up the db and files before making these changes)

If you don't have a backup (which is bad news bears) you should compare your DB to the DB of a new installation of your version and restore the tables and schema_signature to its original state.

Cheers.

@lewishackfath

This comment has been minimized.

Show comment
Hide comment
@lewishackfath

lewishackfath May 14, 2018

I have a backup but it was some time ago and have had people using it since, don't want to lose any of the data/user accounts etc. Might just have to leave it as is.

lewishackfath commented May 14, 2018

I have a backup but it was some time ago and have had people using it since, don't want to lose any of the data/user accounts etc. Might just have to leave it as is.

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev May 14, 2018

Member

@lewishackfath

Actually if you look at the "Files" tab of this pull request you can see all of the .patch.sql and .cleanup.sql files that contain the changes that were made to the database. All you have to do is revert those changes and update the schema_signature with the old one from the include/upgrader/streams/core.sig file in the "Files" tab.

Cheers.

Member

JediKev commented May 14, 2018

@lewishackfath

Actually if you look at the "Files" tab of this pull request you can see all of the .patch.sql and .cleanup.sql files that contain the changes that were made to the database. All you have to do is revert those changes and update the schema_signature with the old one from the include/upgrader/streams/core.sig file in the "Files" tab.

Cheers.

@lewishackfath

This comment has been minimized.

Show comment
Hide comment
@lewishackfath

lewishackfath May 14, 2018

I just deleted the 4 Extra columns created, changed the Schema_signature and replaced the files with those of the latest build and its all working.

lewishackfath commented May 14, 2018

I just deleted the 4 Extra columns created, changed the Schema_signature and replaced the files with those of the latest build and its all working.

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev May 14, 2018

Member

@lewishackfath

Awesome Possum! Just to let you know, the full/stable version of this feature will be released in v1.11rc-1 (coming soon).

Cheers.

Member

JediKev commented May 14, 2018

@lewishackfath

Awesome Possum! Just to let you know, the full/stable version of this feature will be released in v1.11rc-1 (coming soon).

Cheers.

@lewishackfath

This comment has been minimized.

Show comment
Hide comment
@lewishackfath

lewishackfath May 14, 2018

@JediKev Awesome can't wait another company I do work for really wants custom queues but wanted to wait until it was in the official release.

lewishackfath commented May 14, 2018

@JediKev Awesome can't wait another company I do work for really wants custom queues but wanted to wait until it was in the official release.

@MatD73772

This comment has been minimized.

Show comment
Hide comment
@MatD73772

MatD73772 May 24, 2018

so sorry for being a bit slow. I'm trying to do a test of this mod as it's really important that we can view other fields in a ticket list.

So I'm running Apache And MySQL off my laptop using XAMPP. I've downloaded the zip linked at the top of this page, extracted as per usual and run the setup (no other osticket version installed).

If I've installed PHP 5.6, then when I look at settings/tickets, I don't see any tabs
If I've installed PHP 7.0.30, then when I run the setup, I get Fatal Error: Cannot declare class Error, because the name is already in use in c:\xampp\htdcos\osticket\include\class.error.php on line 43. This also happens on PHP 7.2.5.

If I install 1.10.1, that works fine on PHP 7.0.30, but obviously without the important ticket view options..
Am I doing something obviously wrong here ?

thanks

MatD73772 commented May 24, 2018

so sorry for being a bit slow. I'm trying to do a test of this mod as it's really important that we can view other fields in a ticket list.

So I'm running Apache And MySQL off my laptop using XAMPP. I've downloaded the zip linked at the top of this page, extracted as per usual and run the setup (no other osticket version installed).

If I've installed PHP 5.6, then when I look at settings/tickets, I don't see any tabs
If I've installed PHP 7.0.30, then when I run the setup, I get Fatal Error: Cannot declare class Error, because the name is already in use in c:\xampp\htdcos\osticket\include\class.error.php on line 43. This also happens on PHP 7.2.5.

If I install 1.10.1, that works fine on PHP 7.0.30, but obviously without the important ticket view options..
Am I doing something obviously wrong here ?

thanks

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Jul 18, 2018

Member

Thanks for all the comments thus far! This is being released in v1.11 and further issues should be discussed in #4342

Member

greezybacon commented Jul 18, 2018

Thanks for all the comments thus far! This is being released in v1.11 and further issues should be discussed in #4342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment