New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature :: Canned Tasks #2901

Open
wants to merge 18 commits into
base: develop
from

Conversation

Projects
None yet
@greezybacon
Member

greezybacon commented Feb 2, 2016

This implements one of the features outlined in #2826. There it was labelled "Task Templates"

How to Test

  • Checkout the branch from my repo feature/canned-tasks, or visit the branch and download from github
  • Install or upgrade the system normally
  • "Hold on to your butts"

Please feel free to test and report how you view the software implementing your workflow related challenges.

Differences from RFC Posting

Cancellations

Tasks can be cancelled. This is a special case of PENDING, where the task is closed before it is started. Therefore the PENDING flag is never cleared. This is useful to mark tasks as unnecessary when they are included in a set. A screenshot is included below.

Due dates can be based on a related task

Task template due dates can be configured based on the starting date of a related task. For instance, if completing two tasks must happen within a certain period, the second task can use the start time of the first task a reference. A screenshot is included below.

Task Template Groups can be windowed

Task template groups can be associated with a department and/or a help topic. This will help workflows for various departments from be accidentally used or cluttering up the UI for unrelated tickets and departments.

Glossary

I apologize of the verbiage in the pull request differ from the definitions here. That's most of my intention in posting the definitions.

Task Template is a skeleton of a single item in a workflow. This might also be called a Canned Task
Task Template Group is a workflow which includes one or more Task Templates which describe the work items and the interdependency of those items.
Task Set a group of tasks which was added to a Ticket
Dependency is a task which must be completed before a certain task can be started. If task A is a Dependency of task B, then task A must be completed before task B can start. Also, task B depends on task A
Dependent is a task on which a task depends. That is, if task B depends on task A, then task B is a Dependent of task A

Outstanding

  • Installation is missing initial ticket
  • New ticket Issue Summary does not stick
  • Implement enabling and disabling of task templates
  • Implement enabling and disabling of task template groups
  • Add manual start. If a task can be started, then allow an agent to manually start the task
  • Polish and test the upgrader from develop-next

Screenshot Tour

Add a new task template group.

screen shot 2016-02-02 at 11 26 40 am

Visit _Admin Panel > Manage > Canned Tasks_ and add from the popup dialog. Task template groups are logical groups of tasks for a particular work flow, such as installing a new piece of equipment.

Add a template to the new group

screen shot 2016-02-02 at 11 28 29 am

Use the Add Template button to visit a new page to add a template to the group.

screen shot 2016-02-02 at 11 28 45 am

The page looks very simple to the ad-hoc add-task dialog. A few extra fields are added including a complex due date field, dependency selection, and additional forms

Floating due dates

Building off the Pending status, the due dates of templated tasks can be configured to have automated due dates based on several references, including other tasks.

screen shot 2016-02-02 at 1 32 04 pm

Tasks in the template group can be manually sorted and are grouped based on dependencies

screen shot 2016-02-02 at 1 23 58 pm

Add a task template group (workflow) to a ticket

The Add Task button on the ticket view page is outfitted with a new drop-down, which allows adding tasks as a group to a ticket.

screen shot 2016-02-02 at 1 34 58 pm

The dialog allows for a selection of the template group, which only shows the workflows configured for the help topic and/or department of the ticket currently.

screen shot 2016-02-02 at 1 35 49 pm

Additionally, an existing task can be selected as an Initial Dependency. In such a case the first tasks in the workflow are not started immediately. Instead, the are delayed until the referenced task is completed.

Tasks attached to tickets are grouped

screen shot 2016-02-02 at 2 04 03 pm

Also, this is the first mention of a new task state, Pending, which indicates that a task is created, but not yet started. This also implies a deferred due date.

Task in a set show a table of all related tasks

screen shot 2016-02-02 at 1 44 10 pm

This table is omitted from the view when rendering in the ticket-view page, because the listing there already breaks tasks into groups.

Pending tasks start automatically

When a task is closed which is part of a set, all tasks which now have all their dependencies satisfied are automatically started immediately. If they have floating due dates, the due date is calculated based on the automated start time.

screen shot 2016-02-02 at 1 45 32 pm

Notice how the Created time may differ from the Started time

screen shot 2016-02-02 at 1 46 53 pm

Task dependencies are highlighted

At the top of the task view page, a listing of a tasks dependencies are shown along with links to the other tasks and some visual information on their status.

screen shot 2016-02-02 at 1 55 48 pm

Cancelling tasks

As shown above, tasks which have not yet been started can be cancelled. Cancelling is analogous to closing; except that the task is never started. This is useful if the task does not apply to the modeled workflow. For instance, if installing this particular equipment does not replace any other equipment, then decommissioning will likely not be necessary.

@balojs

This comment has been minimized.

Show comment
Hide comment
@balojs

balojs commented Mar 9, 2016

+1

@robintoy

This comment has been minimized.

Show comment
Hide comment
@robintoy

robintoy commented Jun 16, 2016

+1

@robintoy

This comment has been minimized.

Show comment
Hide comment
@robintoy

robintoy Jun 28, 2016

This looks amazing!!!!
Two thumbs very high up on this!

robintoy commented Jun 28, 2016

This looks amazing!!!!
Two thumbs very high up on this!

@nathanzeng

This comment has been minimized.

Show comment
Hide comment
@nathanzeng

nathanzeng Jul 11, 2016

Hi @greezybacon. My apologies but i couldn't create any new tasks or task groups after the initial installation (i was stuck in the loading page). Any guidance? Many thanks.

nathanzeng commented Jul 11, 2016

Hi @greezybacon. My apologies but i couldn't create any new tasks or task groups after the initial installation (i was stuck in the loading page). Any guidance? Many thanks.

@cluck

This comment has been minimized.

Show comment
Hide comment
@cluck

cluck Aug 24, 2016

I can confirm that "Add Task Template Set" is not working.

Log file contains: PHP Fatal error: Call to undefined method VerySimpleModel::create() in /var/www/lib/osticket/include/class.task.php on line 2531

Looks like the code requires a function VerySimpleModel::create() which does not exist.

cluck commented Aug 24, 2016

I can confirm that "Add Task Template Set" is not working.

Log file contains: PHP Fatal error: Call to undefined method VerySimpleModel::create() in /var/www/lib/osticket/include/class.task.php on line 2531

Looks like the code requires a function VerySimpleModel::create() which does not exist.

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Aug 29, 2016

Member

All right gentlemen, I made an effort to reconcile with the upstream changes.

Member

greezybacon commented Aug 29, 2016

All right gentlemen, I made an effort to reconcile with the upstream changes.

@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Aug 29, 2016

Contributor

@greezybacon
Great to see some progress here :)
I really wish I had time to test this and other interesting/promising PRs (like custom queues) :(
Anyway, keep it going! 👍

Cheers!
Michael

Contributor

Chefkeks commented Aug 29, 2016

@greezybacon
Great to see some progress here :)
I really wish I had time to test this and other interesting/promising PRs (like custom queues) :(
Anyway, keep it going! 👍

Cheers!
Michael

@cluck

This comment has been minimized.

Show comment
Hide comment
@cluck

cluck Aug 30, 2016

Very grateful for the work! I'm looking at this patch with interest to understand the latest coding standards for osTicket and how to extend the code :) I'm also looking forward to contribute for linking tasks to a catalog of system operations (shell scripts running in background or AMQP messages sent out, while responses are filled back into the ticket asynchronously completing or failing the task).

For now I found some more issues:

Deleting a "Task Template" on the "Task Template Set" edit page effectively deletes the task template, but sends me back to the "Task Template Sets" page instead of refreshing the current "Task Template Set" page.

The "Add Template" button on the "Task Template Set" does an Ajax call but nothing happens on the UI. No error log on the server, a 200 OK response a large <script type="text/javascript"> in the body.

Editing a "Help Topics" under "New ticket options", the "Add Canned Tasks" remains empty. The previously created Task Template Sets with unrestricted visibility are not shown.

Probably a "Filter Action" should be offered to add canned tasks to tickets.

I'm also thinking how (canned) tasks can be linked to system scripts running outside the web application.

cluck commented Aug 30, 2016

Very grateful for the work! I'm looking at this patch with interest to understand the latest coding standards for osTicket and how to extend the code :) I'm also looking forward to contribute for linking tasks to a catalog of system operations (shell scripts running in background or AMQP messages sent out, while responses are filled back into the ticket asynchronously completing or failing the task).

For now I found some more issues:

Deleting a "Task Template" on the "Task Template Set" edit page effectively deletes the task template, but sends me back to the "Task Template Sets" page instead of refreshing the current "Task Template Set" page.

The "Add Template" button on the "Task Template Set" does an Ajax call but nothing happens on the UI. No error log on the server, a 200 OK response a large <script type="text/javascript"> in the body.

Editing a "Help Topics" under "New ticket options", the "Add Canned Tasks" remains empty. The previously created Task Template Sets with unrestricted visibility are not shown.

Probably a "Filter Action" should be offered to add canned tasks to tickets.

I'm also thinking how (canned) tasks can be linked to system scripts running outside the web application.

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Aug 30, 2016

Member

Editing a "Help Topics" under "New ticket options", the "Add Canned Tasks" remains empty. The previously created Task Template Sets with unrestricted visibility are not shown

Have you enabled your templates?

Probably a "Filter Action" should be offered to add canned tasks to tickets.

Great idea!

Member

greezybacon commented Aug 30, 2016

Editing a "Help Topics" under "New ticket options", the "Add Canned Tasks" remains empty. The previously created Task Template Sets with unrestricted visibility are not shown

Have you enabled your templates?

Probably a "Filter Action" should be offered to add canned tasks to tickets.

Great idea!

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Aug 30, 2016

Member

image

And I fixed the [Add Template] button. @cluck thanks very much for your testing!

Member

greezybacon commented Aug 30, 2016

image

And I fixed the [Add Template] button. @cluck thanks very much for your testing!

@cluck

This comment has been minimized.

Show comment
Hide comment
@cluck

cluck Sep 1, 2016

I've done another round of testing and things look promising.

There is at least one more ::create() that I've hit in include/class.task.php, around line 2213; changing it to a new TaskTemplateForm() worked for me. Note that grep'ing through class.task.php there are other ::create() that probably need be changed.

When deleting a Task Template from a Set, the dialog says that deleted data can not be recovered. This is probably the osTicket standard message but is misleading, as the tasks instantiated from the templates are probably (need to check) preserving their data and it's just the template that is deleted.

After confirming the deletion of a Task Template from a Set I get Warning: call_user_func_array() expects parameter 1 to be a valid callback, cannot access protected method TaskTemplate::setFlag() in /var/www/lib/osticket/include/class.orm.php on line 722, and while the message says Successfully deleted one task template, the task template is not deleted.

The custom forms on tasks are neither shown nor available to be edited still? This would be likely the most welcome of all features about tasks, because tasks tend to be repetitive and thus require structured data (more than tickets actually).

cluck commented Sep 1, 2016

I've done another round of testing and things look promising.

There is at least one more ::create() that I've hit in include/class.task.php, around line 2213; changing it to a new TaskTemplateForm() worked for me. Note that grep'ing through class.task.php there are other ::create() that probably need be changed.

When deleting a Task Template from a Set, the dialog says that deleted data can not be recovered. This is probably the osTicket standard message but is misleading, as the tasks instantiated from the templates are probably (need to check) preserving their data and it's just the template that is deleted.

After confirming the deletion of a Task Template from a Set I get Warning: call_user_func_array() expects parameter 1 to be a valid callback, cannot access protected method TaskTemplate::setFlag() in /var/www/lib/osticket/include/class.orm.php on line 722, and while the message says Successfully deleted one task template, the task template is not deleted.

The custom forms on tasks are neither shown nor available to be edited still? This would be likely the most welcome of all features about tasks, because tasks tend to be repetitive and thus require structured data (more than tickets actually).

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Sep 1, 2016

Member

@cluck thanks for the continued feedback. I think I was able to remedy the issues with saving and displaying the forms on the task templates. I was not able to reproduce the delete issue. I've rebase and re-pushed several times... Could that be part of the problem?

TL;DR: Be careful, create is still valid for many things in the osTicket codebase ...

I imagine the PHP developers think it's a necessary feature... Starting with PHP7, it is a bug if a subclass redefines a method whose call signature is not compatible with the same method defined in any parent. For instance:

class A {
    function say_hello() {
        print "hi";
    }
}

class B extends A {
    function say_hello(array $options) {
        if (!$options['silent'])
            print "hey there";
    }
}
 $ php php7-example.php
PHP Warning:  Declaration of B::say_hello(array $options) should be compatible with A::say_hello() in /path/to/php7-example.php on line 13

This became a problem for us. The ORM defined a create which received an array of items. Those items would become the fields saved to the database. However, something like a Ticket had a different set of parameters. This makes sense from a coding standpoint, because creating a Ticket is different from creating a User which is also different from creating Syslog entry. So the signature was different. When porting to PHP7 this became an issue. So the creation functionality was moved to the constructor in 1ba40e3.

This allows each class to have its constructor match that of the ORM's constructor; however, each class can have a specific signature for its create method which is specific for creating that kind of object.

So, many of the classes still utilize a create method for legacy reasons. However, most of the new stuff has been migrated to perform new-object setup in the object's constructor.

As a sidenote, and to make things even more confusing, when fetching data from the database, the class's constructor is bypassed to prevent confusion between new and existing objects from the database.

Member

greezybacon commented Sep 1, 2016

@cluck thanks for the continued feedback. I think I was able to remedy the issues with saving and displaying the forms on the task templates. I was not able to reproduce the delete issue. I've rebase and re-pushed several times... Could that be part of the problem?

TL;DR: Be careful, create is still valid for many things in the osTicket codebase ...

I imagine the PHP developers think it's a necessary feature... Starting with PHP7, it is a bug if a subclass redefines a method whose call signature is not compatible with the same method defined in any parent. For instance:

class A {
    function say_hello() {
        print "hi";
    }
}

class B extends A {
    function say_hello(array $options) {
        if (!$options['silent'])
            print "hey there";
    }
}
 $ php php7-example.php
PHP Warning:  Declaration of B::say_hello(array $options) should be compatible with A::say_hello() in /path/to/php7-example.php on line 13

This became a problem for us. The ORM defined a create which received an array of items. Those items would become the fields saved to the database. However, something like a Ticket had a different set of parameters. This makes sense from a coding standpoint, because creating a Ticket is different from creating a User which is also different from creating Syslog entry. So the signature was different. When porting to PHP7 this became an issue. So the creation functionality was moved to the constructor in 1ba40e3.

This allows each class to have its constructor match that of the ORM's constructor; however, each class can have a specific signature for its create method which is specific for creating that kind of object.

So, many of the classes still utilize a create method for legacy reasons. However, most of the new stuff has been migrated to perform new-object setup in the object's constructor.

As a sidenote, and to make things even more confusing, when fetching data from the database, the class's constructor is bypassed to prevent confusion between new and existing objects from the database.

@greezybacon greezybacon changed the base branch from develop-next to develop Dec 30, 2016

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Dec 30, 2016

Member

I've rebased this on the v1.10 release for those who are still working on testing

Member

greezybacon commented Dec 30, 2016

I've rebased this on the v1.10 release for those who are still working on testing

@nilschrishahn

This comment has been minimized.

Show comment
Hide comment
@nilschrishahn

nilschrishahn Feb 1, 2017

It looks very nice, but how I can install it into a working 1.10 installation? I tried to upgrade but it didn't work.
Many thanks,
Chris

nilschrishahn commented Feb 1, 2017

It looks very nice, but how I can install it into a working 1.10 installation? I tried to upgrade but it didn't work.
Many thanks,
Chris

@balojs

This comment has been minimized.

Show comment
Hide comment
@balojs

balojs commented Feb 1, 2017

thanks a lot @greezybacon

@dexmox

This comment has been minimized.

Show comment
Hide comment
@dexmox

dexmox Mar 1, 2017

@greezybacon - Great efforts.

Can you please clarify the build say 1.8-git but this looks identical to 1.10 which I am running at the moment.
3 posts back you said you rebased it on v1.10 release is this just theme or is this core?

Look forward to your response;
Have a great day!

Regs,
JV.

dexmox commented Mar 1, 2017

@greezybacon - Great efforts.

Can you please clarify the build say 1.8-git but this looks identical to 1.10 which I am running at the moment.
3 posts back you said you rebased it on v1.10 release is this just theme or is this core?

Look forward to your response;
Have a great day!

Regs,
JV.

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Mar 14, 2017

Member

@dexmox, when we branched to osTicket v1.8, we decided not to branch again. So the branch tag in the source code still reads 1.8-git. However, there is also a MAJOR_VERSION tag added now in bootstrap.php which should be 1.10. So don't be confused. I synchonized it with the develop branch, so it's a feature on top of v1.10.

Member

greezybacon commented Mar 14, 2017

@dexmox, when we branched to osTicket v1.8, we decided not to branch again. So the branch tag in the source code still reads 1.8-git. However, there is also a MAJOR_VERSION tag added now in bootstrap.php which should be 1.10. So don't be confused. I synchonized it with the develop branch, so it's a feature on top of v1.10.

@dexmox

This comment has been minimized.

Show comment
Hide comment
@dexmox

dexmox Mar 14, 2017

I seem to be getting a hang when deleting tickets and cancelling tasks, some errors show in the php.log I am not able to get it but I will post up later can I confirm this is not an issue for you ?

dexmox commented Mar 14, 2017

I seem to be getting a hang when deleting tickets and cancelling tasks, some errors show in the php.log I am not able to get it but I will post up later can I confirm this is not an issue for you ?

@motux

This comment has been minimized.

Show comment
Hide comment
@motux

motux Mar 22, 2017

Thanks a lot, great job

motux commented Mar 22, 2017

Thanks a lot, great job

@motux

This comment has been minimized.

Show comment
Hide comment
@motux

motux Mar 24, 2017

I try this function but the tab of Visibility and Assignment of the Task, when i save the changes, the system don't save anything.
The table ost_task_template_form continue to be empty,.

motux commented Mar 24, 2017

I try this function but the tab of Visibility and Assignment of the Task, when i save the changes, the system don't save anything.
The table ost_task_template_form continue to be empty,.

@rtrice81

This comment has been minimized.

Show comment
Hide comment
@rtrice81

rtrice81 Jul 6, 2017

Is there anyway to merge with with v1.10? and how installed this version and it is working great I am just wondering when it will be merged with v1.10 or added to the core install of osTicket?

Also I have noticed that the canned tasks will not save the assignee or the days until the task is due

rtrice81 commented Jul 6, 2017

Is there anyway to merge with with v1.10? and how installed this version and it is working great I am just wondering when it will be merged with v1.10 or added to the core install of osTicket?

Also I have noticed that the canned tasks will not save the assignee or the days until the task is due

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Jul 6, 2017

Member

@rtrice81 @motux thanks for the feedback. I was able to resolve the issues saving the due date and assignee information.

Member

greezybacon commented Jul 6, 2017

@rtrice81 @motux thanks for the feedback. I was able to resolve the issues saving the due date and assignee information.

@rtrice81

This comment has been minimized.

Show comment
Hide comment
@rtrice81

rtrice81 Jul 7, 2017

@greezybacon tested and confirm that your fix now works as it should for us.
Something else I noticed was that there is no image beside Canned Tasks in the admin panel see screenshot here https://i.imgur.com/B1C2fk5.png
Thank you for this awesome feature, hopefully it will get put into the next stable release

rtrice81 commented Jul 7, 2017

@greezybacon tested and confirm that your fix now works as it should for us.
Something else I noticed was that there is no image beside Canned Tasks in the admin panel see screenshot here https://i.imgur.com/B1C2fk5.png
Thank you for this awesome feature, hopefully it will get put into the next stable release

@F3000

This comment has been minimized.

Show comment
Hide comment
@F3000

F3000 Sep 20, 2017

@greezybacon

Is this feteaure included in 1.10 ?

I can't find this feature.

Is it possible , when i assign a ticket to a specific help topic , osticket generates automatically a task ?

F3000 commented Sep 20, 2017

@greezybacon

Is this feteaure included in 1.10 ?

I can't find this feature.

Is it possible , when i assign a ticket to a specific help topic , osticket generates automatically a task ?

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Sep 20, 2017

Contributor

Q: Is this feature included in 1.10 ?
A: No. It is also not included in 1.10.1. This is an open feature that has not been merged with the main branch at this time.

Contributor

ntozier commented Sep 20, 2017

Q: Is this feature included in 1.10 ?
A: No. It is also not included in 1.10.1. This is an open feature that has not been merged with the main branch at this time.

@F3000

This comment has been minimized.

Show comment
Hide comment
@F3000

F3000 Sep 20, 2017

ok thanks . So i have to wait

F3000 commented Sep 20, 2017

ok thanks . So i have to wait

@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Sep 20, 2017

Member

@F3000 Yes, that feature is in this patch. Navigate to Admin Panel -> Manage -> Help Topics. Then select the relevant help topic. Then select the group of canned tasks which should be generated with new tickets for such a help topic.

Member

greezybacon commented Sep 20, 2017

@F3000 Yes, that feature is in this patch. Navigate to Admin Panel -> Manage -> Help Topics. Then select the relevant help topic. Then select the group of canned tasks which should be generated with new tickets for such a help topic.

@davidegiunchidiennea

This comment has been minimized.

Show comment
Hide comment
@davidegiunchidiennea

davidegiunchidiennea Nov 10, 2017

I've upgraded to ost v1.10.1 and applied this patch: it works good and it's very useful, thank you @greezybacon !
This patch has been available since feb 2016, has been upgraded to the ost versions of this years (it's mantained), it fills an ost gap that the users are asking for since a lot of years (search github, ost forum), the ost's mantainer on 2015 said that this is in the todo list ( #2093 (comment) ), now the question is:

Why this patch has not been included in the ost's core?
There's a roadmap to include it in the next ost's version?

regards

davidegiunchidiennea commented Nov 10, 2017

I've upgraded to ost v1.10.1 and applied this patch: it works good and it's very useful, thank you @greezybacon !
This patch has been available since feb 2016, has been upgraded to the ost versions of this years (it's mantained), it fills an ost gap that the users are asking for since a lot of years (search github, ost forum), the ost's mantainer on 2015 said that this is in the todo list ( #2093 (comment) ), now the question is:

Why this patch has not been included in the ost's core?
There's a roadmap to include it in the next ost's version?

regards

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Nov 12, 2017

Contributor

@davidegiunchidiennea the osTicket roadmap is not public, and I doubt that you will get an answer to those questions.

Contributor

ntozier commented Nov 12, 2017

@davidegiunchidiennea the osTicket roadmap is not public, and I doubt that you will get an answer to those questions.

@davidegiunchidiennea

This comment has been minimized.

Show comment
Hide comment
@davidegiunchidiennea

davidegiunchidiennea Nov 13, 2017

@ntozier Ok, there isn't any roadmap.
There is any idea to include this patch in any next version?
or it will never be included/it's difficult that it will ever be included?

davidegiunchidiennea commented Nov 13, 2017

@ntozier Ok, there isn't any roadmap.
There is any idea to include this patch in any next version?
or it will never be included/it's difficult that it will ever be included?

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev Nov 13, 2017

Member

@davidegiunchidiennea

There is any idea to include this patch in any next version?

Possibly.

or it will never be included/it's difficult that it will ever be included?

It will be included but we don't have a set version or date of release. Stay tuned!

Member

JediKev commented Nov 13, 2017

@davidegiunchidiennea

There is any idea to include this patch in any next version?

Possibly.

or it will never be included/it's difficult that it will ever be included?

It will be included but we don't have a set version or date of release. Stay tuned!

@davidegiunchidiennea

This comment has been minimized.

Show comment
Hide comment
@davidegiunchidiennea

davidegiunchidiennea Nov 13, 2017

@JediKev that's good, Thank you!

davidegiunchidiennea commented Nov 13, 2017

@JediKev that's good, Thank you!

@TuxNDK

This comment has been minimized.

Show comment
Hide comment
@TuxNDK

TuxNDK Jan 25, 2018

I have a new install 1.10.1 and add this patch - not it shows 1.8-git. I can't create tasks as canned or single task as normal. I just return to dialog for create new ticket when I try.
Im new on osticket and maybe I patch the worn way.
I just download repo and overwrite my installation with this. Then it ask for DB upgrade, as I did without problem.

TuxNDK commented Jan 25, 2018

I have a new install 1.10.1 and add this patch - not it shows 1.8-git. I can't create tasks as canned or single task as normal. I just return to dialog for create new ticket when I try.
Im new on osticket and maybe I patch the worn way.
I just download repo and overwrite my installation with this. Then it ask for DB upgrade, as I did without problem.

@Rujinraj

This comment has been minimized.

Show comment
Hide comment
@Rujinraj

Rujinraj Apr 6, 2018

I am using the latest version v1.10.1. How can i patch in my current system with this canned task feature.

Kindly help

Rujinraj commented Apr 6, 2018

I am using the latest version v1.10.1. How can i patch in my current system with this canned task feature.

Kindly help

@ntozier ntozier referenced this pull request Apr 6, 2018

Closed

Task template in v1.10.2 #4223

greezybacon added some commits Jan 21, 2016

thread: Add `started` event
This is used to differentiate between when a task is created and when the
task is started. It will help explain the timeline gaps for dependent canned
tasks, where several tasks are created at the same time but are started in
some hierarchical order rather than simultaneously.

It also adds database support for an `other` event type, which may help in
adding new event types for extensions without the need for special database
modifications.
orm: Cleanup expression API
Everything should extend from SqlExpression, and two expression combined
with an operator should be a BinaryExpression.
forms: Fix missing data for inline form fields
This fixes an issue where the due date for a canned task could not be updated.
tasks: Forbid closure if dependencies are open
This might happen if a dependency is reopened (because of failed approval,
missing or incorrect documentation, etc). In such a case, the subsequent
(dependent) tasks should be frozen. That is, they should not allow the
workflow to continue further along until the dependencies are properly
satisfied.
@greezybacon

This comment has been minimized.

Show comment
Hide comment
@greezybacon

greezybacon Apr 19, 2018

Member

@Rujinraj, I have rebased this branch on the upstream develop branch (v1.10.2). You should be able to check it out or deploy it and run the upgrader. Although, you should definitely try it in a test environment with a copy of your data first, do user acceptance testing, and then consider upgrading your production system.

Member

greezybacon commented Apr 19, 2018

@Rujinraj, I have rebased this branch on the upstream develop branch (v1.10.2). You should be able to check it out or deploy it and run the upgrader. Although, you should definitely try it in a test environment with a copy of your data first, do user acceptance testing, and then consider upgrading your production system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment