New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: custom css include #3259

Open
wants to merge 6 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@ntozier
Contributor

ntozier commented Jul 6, 2016

This PR adds the ability for site admins to specify a custom css /path/to/css/file.css to override or supplement existing css in the Admin panel -> Setting -> System panel.

nst-pr-1

My hope is that this will at least temporarily make plugin devs have an easier time with being able to control what their plugin interface looks like. Originally I didn't include the client side, but decided that someone might want it there also. This should also be a solution for #3064

ntozier added some commits Jul 6, 2016

feature: custom css include
update config class to handle new setting option: custom css
feature: custom css include
add setting field to setting - system page
feature: custom css include
add help tip to default [english] language
Update header.inc.php
update staff header to include the custom css
Update header.inc.php
update client header to include the custom css
@Chefkeks

This comment has been minimized.

Show comment
Hide comment
@Chefkeks

Chefkeks Jul 6, 2016

Contributor

Even though I don't have tested this PR nor intend to use it, I have an idea/suggestion on how to improve it ;)

My suggestion is to define (hardcode) a custom css folder, like the plugin folder, where folks can put the css files and then select via a dropdown (with all css files of that css folder) instead of a text input field.

In case you want to do it really fancy, you could implement a multi-select dropdown, so the users/admins can select several files which will then be combined, so they'd be flexible and could keep css in several files instead of one file in case they like/want to do so.

Btw. also an Disabled or None option / value would be possible in the dropdown which is nice too I think :)

Cheers,
Michael

Contributor

Chefkeks commented Jul 6, 2016

Even though I don't have tested this PR nor intend to use it, I have an idea/suggestion on how to improve it ;)

My suggestion is to define (hardcode) a custom css folder, like the plugin folder, where folks can put the css files and then select via a dropdown (with all css files of that css folder) instead of a text input field.

In case you want to do it really fancy, you could implement a multi-select dropdown, so the users/admins can select several files which will then be combined, so they'd be flexible and could keep css in several files instead of one file in case they like/want to do so.

Btw. also an Disabled or None option / value would be possible in the dropdown which is nice too I think :)

Cheers,
Michael

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Jul 6, 2016

Contributor

I was initially going to do that (re: hardcode dir).... but decided that I wanted people to have the freedom to not have to move their .css files out of their plugin folders. I'm all about plugins not needing to have to edit the core files to work and look the way their devs want them too.

I figured the first step was getting the concept into core, and then if people want to make it better-er (multi select drop downs, toggles to enable/disable, fancy AJAX popups, etc) they can do so.

Contributor

ntozier commented Jul 6, 2016

I was initially going to do that (re: hardcode dir).... but decided that I wanted people to have the freedom to not have to move their .css files out of their plugin folders. I'm all about plugins not needing to have to edit the core files to work and look the way their devs want them too.

I figured the first step was getting the concept into core, and then if people want to make it better-er (multi select drop downs, toggles to enable/disable, fancy AJAX popups, etc) they can do so.

@ArthurBorsboom

This comment has been minimized.

Show comment
Hide comment
@ArthurBorsboom

ArthurBorsboom Oct 12, 2016

Hi,

Since there has been no commits or responses since July 2016 on the original osTicket project, I have decided to create a fork.

https://github.com/ArthurBorsboom/osTicket

There are many developers who have created awesome improvements by pull requests, which are eagerly waiting for merging.

This is an attempt to incorporate most pull requests to get create an improved version of osTicket. Hopefully this can later be reintegrated in the original project, or if the original project is dead as a rebranded project.

Would you mind to offer your pull request again to this fork?

Best regards,
Arthur Borsboom.

ArthurBorsboom commented Oct 12, 2016

Hi,

Since there has been no commits or responses since July 2016 on the original osTicket project, I have decided to create a fork.

https://github.com/ArthurBorsboom/osTicket

There are many developers who have created awesome improvements by pull requests, which are eagerly waiting for merging.

This is an attempt to incorporate most pull requests to get create an improved version of osTicket. Hopefully this can later be reintegrated in the original project, or if the original project is dead as a rebranded project.

Would you mind to offer your pull request again to this fork?

Best regards,
Arthur Borsboom.

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Feb 28, 2017

Contributor

@rayfoss @JediKev @protich
Any chance this might be accepted?

Contributor

ntozier commented Feb 28, 2017

@rayfoss @JediKev @protich
Any chance this might be accepted?

@devosnw

This comment has been minimized.

Show comment
Hide comment
@devosnw

devosnw Oct 6, 2017

Bump. This feature would be extremely helpful for us.

devosnw commented Oct 6, 2017

Bump. This feature would be extremely helpful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment