New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LDAP/AD auth plugin #3456

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
10 participants
@ntozier
Contributor

ntozier commented Nov 3, 2016

removed:
87: ->annotate(array('relevance' => new SqlCode(1)))

This fixes Lookup Create new User Search on open ticket.

Fix for LDAP/AD auth plugin
removed:
87: ->annotate(array('__relevance__' => new SqlCode(1)))

This fixes Lookup Create new User Search on open ticket.
@protich

protich approved these changes Nov 3, 2016

@jdelhome3578

This comment has been minimized.

Show comment
Hide comment
@jdelhome3578

jdelhome3578 Nov 3, 2016

Contributor

@protich Should this filter case insensitive? I have some users where the email has some caps in AD but osTicket has all lower case.

Contributor

jdelhome3578 commented Nov 3, 2016

@protich Should this filter case insensitive? I have some users where the email has some caps in AD but osTicket has all lower case.

@protich

This comment has been minimized.

Show comment
Hide comment
@protich

protich Nov 3, 2016

Member

@jdelhome3578 - good question! As coded it will depend if MySQL is case-sensitive.

Member

protich commented Nov 3, 2016

@jdelhome3578 - good question! As coded it will depend if MySQL is case-sensitive.

@kest874

This comment has been minimized.

Show comment
Hide comment
@kest874

kest874 Nov 3, 2016

Contributor

Confined working finally!

Contributor

kest874 commented Nov 3, 2016

Confined working finally!

@mrdanne

This comment has been minimized.

Show comment
Hide comment
@mrdanne

mrdanne Nov 4, 2016

Did not work for me. Still same error 500.
Or maybe I don't understood...

I removed the line 87: ->annotate(array('relevance' => new SqlCode(1))) in ajax.users.php

mrdanne commented Nov 4, 2016

Did not work for me. Still same error 500.
Or maybe I don't understood...

I removed the line 87: ->annotate(array('relevance' => new SqlCode(1))) in ajax.users.php

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Nov 4, 2016

Contributor

@mrdanne then you do not have the same problem that we had. Which is Search not working in with the LDAP/AD plugin enabled.

500 is a browser/server error which simply means "internal server error". You will have to consult your PHP and/or Apache error logs to find out what the actual logged error is for us to be able to address it.

Contributor

ntozier commented Nov 4, 2016

@mrdanne then you do not have the same problem that we had. Which is Search not working in with the LDAP/AD plugin enabled.

500 is a browser/server error which simply means "internal server error". You will have to consult your PHP and/or Apache error logs to find out what the actual logged error is for us to be able to address it.

@thedaftbadger

This comment has been minimized.

Show comment
Hide comment
@thedaftbadger

thedaftbadger Nov 9, 2016

Fix seems to search for the user now but doesn't actually populate the data required when selecting the found ldap entry.

thedaftbadger commented Nov 9, 2016

Fix seems to search for the user now but doesn't actually populate the data required when selecting the found ldap entry.

@jdelhome3578

This comment has been minimized.

Show comment
Hide comment
@jdelhome3578
Contributor

jdelhome3578 commented Nov 9, 2016

@thedaftbadger

This comment has been minimized.

Show comment
Hide comment
@thedaftbadger

thedaftbadger Nov 9, 2016

@jdelhome3578 Thanks, seems to add the info to the lookup form now 👍 will this still maintain the LDAP link for the user?

thedaftbadger commented Nov 9, 2016

@jdelhome3578 Thanks, seems to add the info to the lookup form now 👍 will this still maintain the LDAP link for the user?

@jdelhome3578

This comment has been minimized.

Show comment
Hide comment
@jdelhome3578
Contributor

jdelhome3578 commented Nov 9, 2016

@terrytibbles

This comment has been minimized.

Show comment
Hide comment
@terrytibbles

terrytibbles Apr 28, 2017

Any idea when this is going to get merged into an official version of osTicket?

terrytibbles commented Apr 28, 2017

Any idea when this is going to get merged into an official version of osTicket?

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Apr 28, 2017

Contributor

It's already been approved.
It is my understanding that will be included in the next release (1.11).

Contributor

ntozier commented Apr 28, 2017

It's already been approved.
It is my understanding that will be included in the next release (1.11).

@jjjeroenski

This comment has been minimized.

Show comment
Hide comment
@jjjeroenski

jjjeroenski May 3, 2017

works for me also!

jjjeroenski commented May 3, 2017

works for me also!

@alexkuc

This comment has been minimized.

Show comment
Hide comment
@alexkuc

alexkuc Jun 13, 2018

Any reason it is not merged despite being given green light?

alexkuc commented Jun 13, 2018

Any reason it is not merged despite being given green light?

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev
Member

JediKev commented Jun 21, 2018

@alexkuc

This comment has been minimized.

Show comment
Hide comment
@alexkuc

alexkuc Jun 21, 2018

@JediKev Oh, my bad! Guess I have missed that comment.

alexkuc commented Jun 21, 2018

@JediKev Oh, my bad! Guess I have missed that comment.

@ntozier

This comment has been minimized.

Show comment
Hide comment
@ntozier

ntozier Jul 24, 2018

Contributor

Side note: this did not make it into 1.10.4. I hear it is in 1.11-rc1 but haven't confirmed for myself.

Contributor

ntozier commented Jul 24, 2018

Side note: this did not make it into 1.10.4. I hear it is in 1.11-rc1 but haven't confirmed for myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment