New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk long text body #3757

Merged
merged 1 commit into from May 13, 2017

Conversation

Projects
None yet
2 participants
@protich
Member

protich commented Mar 18, 2017

Store long thread entry body as an attachment if its length is more than max-length of a text field.

This is necessary especially for emailed tickets which might contain excel document pasted into the body (inline attachment) of the email. We could increase the body field type to longtext - but that won't solve cases where the text is larger than the maximum packet size allowed by MySQL backend.

The technique implemented doesn't require any special flags - we simply set the entry body to NULL and the text is saved as an inline attachment for the entry. The attachment backends stores the file as it see fit - in the case of Database Backend, it already has a built-in chunking mechanism to go around max packet size allowed.

@protich protich merged commit afa31e9 into osTicket:develop May 13, 2017

NFarrington added a commit to VATSIM-UK/Helpdesk that referenced this pull request Oct 7, 2017

Merge tag 'v1.10.1' into development
osTicket v1.10.1

Maintenance release for osTicket 1.10

=== Enhancements
- Users: Support search by phone number
- i18n: Fix getPrimaryLanguage() on non-object (#3799)
- Add TimezoneField (#3786)
- Chunk long text body (#3757, 7b68c99)
- Spyc: convert hex strings to INTs under PHP 7 (#3621)
- forms: Proper Field Deletion
- Move orphaned tasks on department deletion to the default department (42e2c55)
- List: Save List Item Abbreviation (8513f13)

=== Performance and Security
- XSS: Encode html entities of advanced search title (#3919)
- XSS: Encode html entities of cached form data (#3960, bcd58e8)
- ORM: Addresses an SQL injection vulnerability in ORM lookup function (#3959, 1eaa691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment