New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Outlook _MailEndCompose #4206

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@JediKev
Member

JediKev commented Mar 23, 2018

This addresses an issue where Outlook adds weird (and seemingly random)
_MailEndCompose tags to the email body which turns unwanted content into
links. This adds the _MailEndCompose tag to Format::sanitize() so it
will be removed from the email body.

@sperows

This comment has been minimized.

Show comment
Hide comment
@sperows

sperows Mar 26, 2018

Hm, I don't know why, but my tickets, created via inc mail, were created with "(empty)" body after applying this patch.

HTML warnings:
PHP Warning: preg_replace(): Unknown modifier '(' in ............./include/class.format.php on line 312

My commit:
image

sperows commented Mar 26, 2018

Hm, I don't know why, but my tickets, created via inc mail, were created with "(empty)" body after applying this patch.

HTML warnings:
PHP Warning: preg_replace(): Unknown modifier '(' in ............./include/class.format.php on line 312

My commit:
image

issue: Outlook _MailEndCompose
This addresses an issue where Outlook adds weird (and seemingly random)
_MailEndCompose tags to the email body which turns unwanted content into
links. This adds the _MailEndCompose tag to Format::sanitize() so it
will be removed from the email body.
@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev Mar 26, 2018

Member

@sperows

Ooops....left off the delimiters by accident. It's updated now, so please re-pull and test again. 👍

Cheers.

Member

JediKev commented Mar 26, 2018

@sperows

Ooops....left off the delimiters by accident. It's updated now, so please re-pull and test again. 👍

Cheers.

@sperows

This comment has been minimized.

Show comment
Hide comment
@sperows

sperows Mar 27, 2018

That did the trick :) Thank you, I can't believe I did not notice the ":" hah.

sperows commented Mar 27, 2018

That did the trick :) Thank you, I can't believe I did not notice the ":" hah.

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev Mar 27, 2018

Member

@sperows

I can't believe that I forgot lol 😑

Member

JediKev commented Mar 27, 2018

@sperows

I can't believe that I forgot lol 😑

@protich protich merged commit 1f9de0f into osTicket:develop Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment