New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Files - deleteOrphans() #4253

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
3 participants
@JediKev
Member

JediKev commented Apr 25, 2018

This addresses the issue where files were being deleted before being sent
out in Agent responses. This was due to a bug in the query that gets the
orphaned files. This query was getting files created within the last 24
hours not after the last 24 hours. The query also had another bug that
would use the time from PHP instead of MySQL which could cause issues.
This updates the query as per @greezybacon's suggestions to delete
orphaned files that were created more than 24 hours ago.

issue: Files - deleteOrphans()
This addresses the issue where files were being deleted before being sent
out in Agent responses. This was due to a bug in the query that gets the
orphaned files. This query was getting files created within the last 24
hours not after the last 24 hours. The query also had another bug that
would use the time from PHP instead of MySQL which could cause issues.
This updates the query as per @greezybacon's suggestions to delete
orphaned files that were created more than 24 hours ago.
@toyowheelin

This comment has been minimized.

Show comment
Hide comment
@toyowheelin

toyowheelin Jul 10, 2018

@JediKev Thanks for the pointer, I will see if I can apply the patch to my install.

toyowheelin commented Jul 10, 2018

@JediKev Thanks for the pointer, I will see if I can apply the patch to my install.

@toyowheelin

This comment has been minimized.

Show comment
Hide comment
@toyowheelin

toyowheelin Aug 7, 2018

So I thought this patch fixed the issue I was seeing where people would have their attachments go missing, but now today out of the blue with no changes I just got a few more reports of this same issue. Do you know if this fix works with the file backend storage plugin or is it only for storing data in SQL?

toyowheelin commented Aug 7, 2018

So I thought this patch fixed the issue I was seeing where people would have their attachments go missing, but now today out of the blue with no changes I just got a few more reports of this same issue. Do you know if this fix works with the file backend storage plugin or is it only for storing data in SQL?

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev Aug 7, 2018

Member

@toyowheelin

As far as I know it should fix all of it; but I haven't tested it with the plugins as I don't use them.

There was a different commit in-line with this one to help the performance so maybe you need that as well:
#4247

Cheers.

Member

JediKev commented Aug 7, 2018

@toyowheelin

As far as I know it should fix all of it; but I haven't tested it with the plugins as I don't use them.

There was a different commit in-line with this one to help the performance so maybe you need that as well:
#4247

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment