New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Language Pack Locale Mismatch #4326

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
3 participants
@JediKev
Member

JediKev commented Jul 3, 2018

This addresses issue #4325 where the Language Pack Locales are mismatched.
The Locale for the first language is displayed on the second language,
etc. This updates the $manifest variable to be set before we display
data so the correct MANIFEST file is included and all language data is
displayed correctly.

issue: Language Pack Locale Mismatch
This addresses issue 4325 where the Language Pack Locales are mismatched.
The Locale for the first language is displayed on the second language,
etc. This updates the `$manifest` variable to be set before we display
data so the correct `MANIFEST` file is included and all language data is
displayed correctly.
@qatuno

This comment has been minimized.

Show comment
Hide comment
@qatuno

qatuno Jul 3, 2018

So, i do know nothing. But would like to test and patch my fork for building up and run a new machine. Somehow i'm new into github. Just some system integrater who is always up and can't sleep. In the end i'm not 100% sure if it is about the problem i have on to my running installation.

qatuno commented Jul 3, 2018

So, i do know nothing. But would like to test and patch my fork for building up and run a new machine. Somehow i'm new into github. Just some system integrater who is always up and can't sleep. In the end i'm not 100% sure if it is about the problem i have on to my running installation.

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev Jul 3, 2018

Member

@qatuno

Unfortunately I do not understand your question. Could you rephrase it for me?

Cheers.

Member

JediKev commented Jul 3, 2018

@qatuno

Unfortunately I do not understand your question. Could you rephrase it for me?

Cheers.

@qatuno

This comment has been minimized.

Show comment
Hide comment
@qatuno

qatuno Jul 3, 2018

Yes sure. How do i use this patch? Is it already usable out of the main repository. Or do i really need to fork this into my own repository. Sorry me, Please don't get me wrong. Even if it sounds stupid. my running installation reacts nearly like described, but i did a workaround and in the end there was one translation with some new strange behavior. It did not accept the input. Just still shown further some text, which is shown different on to the webpage as at the editor.

qatuno commented Jul 3, 2018

Yes sure. How do i use this patch? Is it already usable out of the main repository. Or do i really need to fork this into my own repository. Sorry me, Please don't get me wrong. Even if it sounds stupid. my running installation reacts nearly like described, but i did a workaround and in the end there was one translation with some new strange behavior. It did not accept the input. Just still shown further some text, which is shown different on to the webpage as at the editor.

@JediKev

This comment has been minimized.

Show comment
Hide comment
@JediKev

JediKev Jul 3, 2018

Member

@qatuno

It does not sound stupid 🙂

If your current installation is a download from http://osticket.com/download the best way is to make the changes manually by editing your current installation’s codebase. If your current installation is a clone of the repo then you can pull this pull request locally and merge it to your codebase. If you can’t do any of the above then you can wait until it is approved/merged and released in the next version.

Cheers.

Member

JediKev commented Jul 3, 2018

@qatuno

It does not sound stupid 🙂

If your current installation is a download from http://osticket.com/download the best way is to make the changes manually by editing your current installation’s codebase. If your current installation is a clone of the repo then you can pull this pull request locally and merge it to your codebase. If you can’t do any of the above then you can wait until it is approved/merged and released in the next version.

Cheers.

@qatuno

This comment has been minimized.

Show comment
Hide comment
@qatuno

qatuno Jul 3, 2018

sounds good. told you i can't sleep and always looking for something interesting. this is an experience to me, like to learn. I'm some autodidact. This and all the cases which i like to get into.
If you like to know. I'm very much into OsTicket. It is an fine solution for some one who worked into service and had seen many plattforms and needed to work with. Nice straight forward.

all the best

qatuno commented Jul 3, 2018

sounds good. told you i can't sleep and always looking for something interesting. this is an experience to me, like to learn. I'm some autodidact. This and all the cases which i like to get into.
If you like to know. I'm very much into OsTicket. It is an fine solution for some one who worked into service and had seen many plattforms and needed to work with. Nice straight forward.

all the best

qatuno added a commit to qatuno/osTicket that referenced this pull request Jul 3, 2018

@protich protich merged commit 928c0da into osTicket:develop Jul 13, 2018

Jeija added a commit to physcip/osTicket that referenced this pull request Jul 17, 2018

Merge tag 'v1.10.4' into physcip
osTicket v1.10.4

Maintenance release for osTicket 1.10

=== Enhancements
 * issue: Auto-Assignment Log (osTicket#4316)
 * issue: Language Pack Locale Mismatch (osTicket#4326)
 * issue: CLI Deploy Missing Bootstrap (osTicket#4332)
 * issue: User Import No Email (osTicket#4330)
 * issue: Ticket Lock On Disable (osTicket#4335)

=== Performance and Security
 * security: Fix Multiple XSS Vulnerabilities (osTicket#4331)
 * department: Error Feedback (osTicket#4331)

jasonhoward7 added a commit to nycmeshnet/osTicket that referenced this pull request Sep 11, 2018

Merge tag 'v1.10.4' of https://github.com/osTicket/osTicket into develop
osTicket v1.10.4

Maintenance release for osTicket 1.10

=== Enhancements
 * issue: Auto-Assignment Log (osTicket#4316)
 * issue: Language Pack Locale Mismatch (osTicket#4326)
 * issue: CLI Deploy Missing Bootstrap (osTicket#4332)
 * issue: User Import No Email (osTicket#4330)
 * issue: Ticket Lock On Disable (osTicket#4335)

=== Performance and Security
 * security: Fix Multiple XSS Vulnerabilities (osTicket#4331)
 * department: Error Feedback (osTicket#4331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment