Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filedrop: Fix file drag and drop #4719

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@greezybacon
Copy link
Member

commented Feb 12, 2019

This fixes an issue introduced in the upgrade to jQuery three. The filedrop field was not updated correctly and drag and drop files was broken.

Additionally, this handles cases where files are dragged over the box but not dropped. The style of the box is correctly reset after the drag leaves the box.

@greezybacon greezybacon requested a review from JediKev Feb 12, 2019

filedrop: Fix file drag and drop
This fixes an issue introduced in the upgrade to jQuery three. The filedrop
field was not updated correctly and drag and drop files was broken.
Additionally, this handles cases where files are dragged over the box but
not dropped. The style of the box is correctly reset after the drag leaves
the box.

@greezybacon greezybacon force-pushed the greezybacon:issue/jq-3-file-drop branch from e01314f to 0c6e486 Feb 12, 2019

jQuery: Fix default slow appearance of .show()
With the patch introduced to fix the `afterShow` event for jQuery three,
this appear sort of slowly be default. This addresses the issue by providing
a default of 0ms to show things, so they show immediately.

@greezybacon greezybacon force-pushed the greezybacon:issue/jq-3-file-drop branch from 0c6e486 to c2fdc0a Feb 12, 2019

@protich protich merged commit 8d01b1f into osTicket:develop-next Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.