Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: Complete Thread ASC or DESC #4737

Merged

Conversation

Projects
None yet
4 participants
@JediKev
Copy link
Member

commented Feb 14, 2019

This pull adds the ability to choose between ASC or DESC order for the complete thread variable. If complete_asc is chosen the system will order the thread in ASC order, if complete_desc is chosen the system will order the thread in DESC order. This keeps backwards compatibility with just complete as some people might forget to update this for a while.

@greezybacon

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

I would suggest %{object.thread.reversed}. I find complete_asc to be a bit technical.

@FG-Lars

This comment has been minimized.

Copy link

commented Mar 7, 2019

Might I suggest adding some space below the agent's reply by default? (descending order)

image

Excellent feature btw. Been waiting for this one.

@JediKev JediKev force-pushed the JediKev:variable/complete-thread-asc-or-desc branch from 3f79e2c to 191b399 Mar 26, 2019

variable: Complete Thread ASC or DESC
This pull adds the ability to choose between ASC or DESC order for the
complete thread variable. If `complete_asc` is chosen the system will order
the thread in ASC order, if `complete_desc` is chosen the system will order
the thread in DESC order. This keeps backwards compatibility with just
`complete` as some people might forget to update this for a while.

@JediKev JediKev force-pushed the JediKev:variable/complete-thread-asc-or-desc branch from 191b399 to 84d05c6 Mar 27, 2019

@protich protich merged commit e95f0e2 into osTicket:develop-next Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.