Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Assignment Restriction Issue #4744
This commit fixes an issue where we were not checking the restrictions on Ticket assignment correctly. isAccessLimited returns true if showAssignedOnly is true, so we wouldn't want to negate the isAccessLimited check (that would return true if access is not limited).
Also, if an Agent's access is limited to assigned tickets only, we can return the assigned tickets once we have them without needing to go through any further processing.
Note: queue counts update themselves a little after you toggle the 'Limit ticket access to ONLY assigned tickets' check box. The 'See all tickets in search results, regardless of access' still works correctly as well.
referenced this pull request
Feb 22, 2019
When testing it, it's true that agents still have access to tickets that they only have access to via assignment as long as the ticket is open. Shouldn't they still have access though even if the ticket is closed? I modified my code to allow that access, but if we still want to restrict it, just let me know and I can put that restriction back.
@aydreeihn - No - closed tickets are no longer assigned, since closing agent might not necessarily be the agent who was assigned.
To extend access to previously assigned agents or closing agents we would have to add auto-referral (which is really assignment) with a setting to enable it.