Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: FAQ Search Results #4771

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@JediKev
Copy link
Member

commented Mar 4, 2019

This addresses an issue reported on the forum where searching for a keyword in FAQ search brings back more results than it should. This is due to the format of the query selecting the results, essentially, the WHERE NOT statement is not properly formatted so the OR statements take precedence over the WHERE NOT causing non-public results to be shown to the client. The WHERE NOT statement contains the bit to select from only public faqs and since the OR takes precedence it will return the non-public results too.

issue: FAQ Search Results
This addresses an issue reported on the forum where searching for a keyword
in FAQ search brings back more results than it should. This is due to the
format of the query selecting the results, essentially, the `WHERE NOT`
statement is not properly formatted so the `OR` statements take precedence
over the `WHERE NOT` causing non-public results to be shown to the client.
The `WHERE NOT` statement contains the bit to select from only public faqs
and since the `OR` takes precedence it will return the non-public results
too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.