Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Ticket Export Headers #4796

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@aydreeihn
Copy link
Contributor

commented Mar 14, 2019

This commit fixes an issue where custom export headings were being set to numeric values rather than field labels.

For exports that are already saved, we can get the heading directly using getHeading. To get the heading for fields that are not already saved as exports, we can use getExportableFields, which will return path => heading.

$f->set('heading', $heading);
$f->set('sort', array_search($key, $order)+1);
unset($new[$key]);
}
foreach ($new as $k => $field) {
if (is_array($field))
$exportableFields = CustomQueue::getExportableFields();

This comment has been minimized.

Copy link
@protich

protich Mar 21, 2019

Member

Move this outside foreach loop.

This comment has been minimized.

Copy link
@aydreeihn

aydreeihn Mar 22, 2019

Author Contributor

Fixed

@aydreeihn aydreeihn force-pushed the aydreeihn:issue/export-headers branch 2 times, most recently from 2e0fa71 to 8fd90e5 Mar 22, 2019

Issue: Ticket Export Headers
This commit fixes an issue where custom export headings were being set to numeric values rather than field labels.

For exports that are already saved, we can get the heading directly using getHeading. To get the heading for fields that are not already saved as exports, we can use getExportableFields, which will return path => heading.

@aydreeihn aydreeihn force-pushed the aydreeihn:issue/export-headers branch from 8fd90e5 to e26f62f Apr 1, 2019

@protich protich merged commit 5f511d8 into osTicket:develop-next Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.