Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Choice Validation Accept Punctuation #4847

Conversation

Projects
None yet
2 participants
@JediKev
Copy link
Member

commented Apr 12, 2019

This addresses issue mentioned in #4071 where the choice field validation is not accepting punctuations. This updates the regex to accept anything the user inputs. This introduces another issue that if the choice contains : in the value then it will truncate everything after. This is due to the explode method that explodes on any : character. This updates the explode method to return only 2 values which only explodes on one : character which returns the full value.

issue: Choice Validation Accept Punctuation
This addresses issue mentioned in 4071 where the choice field validation is
not accepting punctuations. This updates the regex to accept anything the
user inputs. This introduces another issue that if the choice contains `:`
in the value then it will truncate everything after. This is due to the
explode method that explodes on any `:` character. This updates the explode
method to return only 2 values which only explodes on one `:` character
which returns the full value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.