Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: .eml/.msg Attachments #4857

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@JediKev
Copy link
Member

commented Apr 17, 2019

This addresses an issue where .eml and .msg files on incoming mails are being dropped. This is due the the mail fetcher that tries to process .eml/.msg files and adds them as thread entries rather than adding them as attachments. This adds a new section that utilizes a new method to fetch the body of .eml/.msg files, fetches the subjects of the .eml/.msg files as the attachment names, and creates attachments. This preserves the .eml and .msg files and adds them to the pertinent thread entries as attachments.

issue: .eml/.msg Attachments
This addresses an issue where `.eml` and `.msg` files on incoming mails are
being dropped. This is due the the mail fetcher that tries to process
`.eml`/`.msg` files and adds them as thread entries rather than adding them
as attachments. This adds a new section that utilizes a new method to fetch
the body of `.eml`/`.msg` files, fetches the subjects of the `.eml`/`.msg`
files as the attachment names, and creates attachments. This preserves the
`.eml` and `.msg` files and adds them to the pertinent thread entries as
attachments.
$body = $this->fetchBody($mid, $info['index'].'.0',
$info['encoding']);
// Add fake body to make the parser happy
if ($body)

This comment has been minimized.

Copy link
@protich

protich Apr 17, 2019

Member

Wonder is this was meant to be if(!$body)

This comment has been minimized.

Copy link
@JediKev

JediKev Apr 17, 2019

Author Member

I already have this in my notes to discuss with you tomorrow 😂

@protich

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@JediKev - I think we need equivalent implementation for mail parse (piping).

@JediKev

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

@protich Will look into it.

@protich

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Check stashed changes before looking into it... I don't remember porting the changes to class.mailparse.php but it has been many moons ;)

@JediKev

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

@protich Aye aye cap’n!

@protich protich merged commit 3299278 into osTicket:develop Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.