Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGlobalScopeProvider enhancement #1089

Closed
joeseibel opened this issue Mar 7, 2018 · 2 comments
Closed

IGlobalScopeProvider enhancement #1089

joeseibel opened this issue Mar 7, 2018 · 2 comments
Assignees
Milestone

Comments

@joeseibel
Copy link
Contributor

@joeseibel joeseibel commented Mar 7, 2018

We should create a custom IGlobalScopeProvider which takes an EClass instead of an EReference. Callers of the global scope should then inject the Aadl2GlobalScopeProvider instead of IGlobalScopeProvider.

child #1018
needed by #1254

@joeseibel joeseibel self-assigned this Mar 7, 2018
@lwrage lwrage added the backlog label Mar 14, 2018
@lwrage
Copy link
Contributor

@lwrage lwrage commented Apr 18, 2018

Need a method to look up a type in the global scope given an emf Resource, another given an IProject.

@lwrage lwrage added next and removed backlog labels May 30, 2018
@lwrage lwrage added this to the 2.3.4 milestone May 30, 2018
@lwrage
Copy link
Contributor

@lwrage lwrage commented May 30, 2018

We already have an Aadl2GlobalScopeProvider. It add's methods to check for duplicates, which can likely be done in a better place. Also, these methods use resource descriptions, and that doesn't work in JUnit tests.

@ghost ghost added in progress and removed next labels May 31, 2018
@ghost ghost added review and removed in progress labels May 31, 2018
@lwrage lwrage closed this in #1283 Jun 1, 2018
@ghost ghost removed the review label Jun 1, 2018
@lwrage lwrage added the core label Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.