New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential AnnexParseUtil Thread Safety #1146

Closed
philip-alldredge opened this Issue Apr 18, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@philip-alldredge
Collaborator

philip-alldredge commented Apr 18, 2018

Summary

While using OSATE(with the graphical editor), the user interface hung. Two thread dumps are attached. They are taken from the same event. Multiple dumps were taken to allow looking for changes in the thread's state.
d3.txt
d2.txt

From my perspective, it looks like the issue is in AnnexParseUtil's usage of the parseResults hash map internally. The main thread is stuck in a loop in WeakHashMap while trying to put an entry into the map. I believe this indicates that the data structure is corrupted since the thread doesn't block and is in a seemingly endless loop. I suspect that synchronizing the usage of the map would fix the issue. However, I'm not aware of what could have triggered such behavior. I suspect it is Xtext performing a rebuild while the graphical editor is opening a resource. Unable to confirm.

Steps to Reproduce

Unable to reliable reproduce. As the time it occurred I performing small changes and saves to various resources and selecting various Eclipse views.

Environment

  • OSATE Version:
  • Platform: Windows
@lwrage

This comment has been minimized.

Show comment
Hide comment
@lwrage

lwrage Jul 2, 2018

Contributor

@philip-alldredge I can't look at the thread dumps. I only get a 404 error when clicking on the links.

Contributor

lwrage commented Jul 2, 2018

@philip-alldredge I can't look at the thread dumps. I only get a 404 error when clicking on the links.

@philip-alldredge

This comment has been minimized.

Show comment
Hide comment
@philip-alldredge

philip-alldredge Jul 2, 2018

Collaborator

@lwrage I updated the post to take the -core out of the URL. That seems to have fixed the links.

Collaborator

philip-alldredge commented Jul 2, 2018

@lwrage I updated the post to take the -core out of the URL. That seems to have fixed the links.

@wafflebot wafflebot bot added the in progress label Jul 3, 2018

@lwrage lwrage added the category:bug label Jul 3, 2018

@lwrage lwrage added this to the 2.3.5 milestone Jul 3, 2018

@lwrage

This comment has been minimized.

Show comment
Hide comment
@lwrage

lwrage Jul 6, 2018

Contributor

I'll synchronize the WeakHashMap.

Contributor

lwrage commented Jul 6, 2018

I'll synchronize the WeakHashMap.

@lwrage lwrage added the core label Jul 9, 2018

@wafflebot wafflebot bot added review and removed in progress labels Jul 23, 2018

@lwrage lwrage closed this in #1397 Jul 24, 2018

@wafflebot wafflebot bot removed the review label Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment