New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for Unlock When Editing Diagrams in Subversion Repository #1217

Closed
philip-alldredge opened this Issue Apr 30, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@philip-alldredge
Collaborator

philip-alldredge commented Apr 30, 2018

This is in related to and is in addition to #1132. IWorkspace.validateEdit needs to be called before making changes to diagram files. This should prompt the user to unlock the file. If validation fails, the change should not be made.

Ensure that the user is not prompted multiple times when making changes that affect multiple diagram files such as refactoring.

@lwrage lwrage added category:bug and removed bug labels May 31, 2018

philip-alldredge added a commit that referenced this issue Aug 1, 2018

Improve SVN locking upport
Implemented basic support for checking if diagrams are editable and
unlocking using validateEdit. Improves SVN support. Closes #1217

@wafflebot wafflebot bot added in progress and removed backlog labels Aug 1, 2018

@wafflebot wafflebot bot added review and removed in progress labels Aug 1, 2018

@philip-alldredge

This comment has been minimized.

Show comment
Hide comment
@philip-alldredge

philip-alldredge Aug 1, 2018

Collaborator

There are two SVN clients for Eclipse: subclipse and subversive. Subversive seems to have more problems than subclipse. When using subversive, an NPE occured when renaming via LTK from the grpahical editor under certain circumstances. This issue is not resolvable without changes to Xtext or Subversive. For graphical editor usages, the behavior is more reliable when using subclipse.

Prompting to unlock AADL source files and diagrams when appropriate when editing in the graphical editor is needed. However, subclipse may automatically attempt to lock files in some cases such as when refactoring elements using LTK. Unfortunately, this operation may fail if one of the files is already locked. In such cases an error is printed by subclipse to the console describing the problem.

Collaborator

philip-alldredge commented Aug 1, 2018

There are two SVN clients for Eclipse: subclipse and subversive. Subversive seems to have more problems than subclipse. When using subversive, an NPE occured when renaming via LTK from the grpahical editor under certain circumstances. This issue is not resolvable without changes to Xtext or Subversive. For graphical editor usages, the behavior is more reliable when using subclipse.

Prompting to unlock AADL source files and diagrams when appropriate when editing in the graphical editor is needed. However, subclipse may automatically attempt to lock files in some cases such as when refactoring elements using LTK. Unfortunately, this operation may fail if one of the files is already locked. In such cases an error is printed by subclipse to the console describing the problem.

@philip-alldredge philip-alldredge added this to the 2.3.5 milestone Aug 1, 2018

philip-alldredge added a commit that referenced this issue Aug 2, 2018

Improve SVN locking support (#1426)
Implemented basic support for checking if diagrams are editable and
unlocking using validateEdit. Improves SVN support. Closes #1217

@wafflebot wafflebot bot removed the review label Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment