New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error about feature directions in inverse feature group #1233

Closed
rinsley opened this Issue May 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@rinsley
Contributor

rinsley commented May 9, 2018

I'm getting an error in this snippet of AADL in the AADL text editor:

feature group OutputGroup
	features
		Out1: out feature;
end OutputGroup;

feature group OutputGroupInverse inverse of OutputGroup
end OutputGroupInverse;

system Sys
	features
		IG1: in feature group inverse of OutputGroup;
		IG2: in feature group OutputGroupInverse;
end Sys;

IG1 and IG2 should both be valid as "in" direction groups, but IG2 is giving the error "All ports, parameters, feature groups, and abstract features in the referenced feature group type must satisfy the direction specified in the feature group."

@lwrage lwrage added the category:bug label May 10, 2018

@lwrage lwrage added this to the 2.3.4 milestone May 10, 2018

@lwrage lwrage added next and removed backlog labels Jun 11, 2018

@lwrage

This comment has been minimized.

Show comment
Hide comment
@lwrage

lwrage Jun 28, 2018

Contributor

There are various edge cases where it is unclear what should be considered a valid model, e.g., feature groups without a type, feature groups with an empty type.
Also, should access features in a feature group be ignored in the validation, or should they result in an error?

Contributor

lwrage commented Jun 28, 2018

There are various edge cases where it is unclear what should be considered a valid model, e.g., feature groups without a type, feature groups with an empty type.
Also, should access features in a feature group be ignored in the validation, or should they result in an error?

@wafflebot wafflebot bot added in progress and removed next labels Jun 28, 2018

lwrage added a commit that referenced this issue Jun 28, 2018

@wafflebot wafflebot bot added review and removed in progress labels Jun 28, 2018

@lwrage lwrage closed this in #1367 Jun 30, 2018

@wafflebot wafflebot bot removed the review label Jun 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment