Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error about feature directions in inverse feature group #1233

Closed
rinsley opened this issue May 9, 2018 · 1 comment
Closed

Incorrect error about feature directions in inverse feature group #1233

rinsley opened this issue May 9, 2018 · 1 comment

Comments

@rinsley
Copy link
Contributor

rinsley commented May 9, 2018

I'm getting an error in this snippet of AADL in the AADL text editor:

feature group OutputGroup
	features
		Out1: out feature;
end OutputGroup;

feature group OutputGroupInverse inverse of OutputGroup
end OutputGroupInverse;

system Sys
	features
		IG1: in feature group inverse of OutputGroup;
		IG2: in feature group OutputGroupInverse;
end Sys;

IG1 and IG2 should both be valid as "in" direction groups, but IG2 is giving the error "All ports, parameters, feature groups, and abstract features in the referenced feature group type must satisfy the direction specified in the feature group."

@lwrage
Copy link
Contributor

lwrage commented Jun 28, 2018

There are various edge cases where it is unclear what should be considered a valid model, e.g., feature groups without a type, feature groups with an empty type.
Also, should access features in a feature group be ignored in the validation, or should they result in an error?

@ghost ghost assigned lwrage Jun 28, 2018
@ghost ghost added in progress and removed next labels Jun 28, 2018
lwrage added a commit that referenced this issue Jun 28, 2018
@ghost ghost added review and removed in progress labels Jun 28, 2018
@ghost ghost removed the review label Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants