New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error text for feature group inverse error #1234

Closed
rinsley opened this Issue May 9, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@rinsley
Contributor

rinsley commented May 9, 2018

This bit of AADL attempts two different ways of creating feature groups that are inverses of inverses:

feature group MyGroup
end MyGroup;

feature group MyGroupInverse inverse of MyGroup
end MyGroupInverse;

feature group FG1 inverse of MyGroupInverse
end FG1;

system Sys
	features
		FG2: feature group inverse of MyGroupInverse;
end Sys;

This correctly results in two errors in the AADL text editor. The first error about FG1 says, "A feature group type cannot be an inverse of another feature group type that already contains an 'inverse of' declaration."

However, the second error about FG2 says, "A feature group type with an 'inverse of' declaration cannot extend a feature group type without an 'inverse of' declaration."

The text in the second case doesn't make sense (looks like it was copied from another error message in Aadl2JavaValidator). It should probably say something similar to the first error message: for example, "A feature group cannot be an inverse of a feature group type that already contains an 'inverse of' declaration."

@lwrage lwrage added this to the 2.3.4 milestone May 31, 2018

@lwrage lwrage self-assigned this Jun 28, 2018

lwrage added a commit that referenced this issue Jun 28, 2018

@wafflebot wafflebot bot added in progress and removed next labels Jun 28, 2018

@wafflebot wafflebot bot added review and removed in progress labels Jun 28, 2018

@wafflebot wafflebot bot removed the review label Jun 29, 2018

@lwrage lwrage added the core label Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment