Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams are automaticly marked as changed #1246

Closed
stevevestal opened this Issue May 16, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@stevevestal
Copy link

stevevestal commented May 16, 2018

Summary

When I save a diagram, a few seconds later the Zoom Out icon flickers a few times, and the diagram is marked dirty again. I do not see any visual changes in the diagram itself. Selecting save causes this behavior to repeat.

Expected and Current Behavior

Steps to Reproduce

This always happens for me, but I suspect it might have to do with my configuration. I am running this as an Eclipse Application from within Eclipse RCP. (I would rank this low priority/ a curiosity unless it is happening in more typical user configurations.)

Environment

  • OSATE Version: OSATE nightly test installed into Eclipse Oxygen RCP with ELK 0.3.0.
  • Operating System: Windows 10
@stevevestal

This comment has been minimized.

Copy link
Author

stevevestal commented May 16, 2018

Not all diagrams. Only some. The only difference I can see is that the ones that auto-dirty are too large (at the default 100%) to fit in any single screen. Changing the default zoom, or shrinking the window size for the diagram that does not do this, doesn't make any difference.

@philip-alldredge

This comment has been minimized.

Copy link
Collaborator

philip-alldredge commented May 17, 2018

This should be investigated when looking at similar issues. See #1199. The more information the better but when we rework how the dirty detection is determined, this issue should be fixed.

@philip-alldredge philip-alldredge self-assigned this Jun 5, 2018

philip-alldredge added a commit that referenced this issue Jun 19, 2018

Undo/Redo rework.
Implements #1182, #1199, and #1246.

Replaces the current undo capability that is is
very limited with an implementation that allow undoing and redoing a
wider range of actions. Usage of the text editor can degrade
capabilities.

- Removed implementation of ICustomUndoRedoFeature. Graphiti undo/redo
no longer needed
- Removed ability to disable Graphiti modification listener. No longer
necessary with new undo implementation.
- Added undo support for add/remove element
- Added undo support for ghosting
- Added undo support for setDiagramConfiguration
- Added ActionService, AgeAction, and ActionExecutor
- Implemented global undo/redo stacks.
- Reworked interface between AgeDiagram, GraphitiAgeDiagram, and
AgeDiagramEditor to use AgeAction interface.
- Undo/Redo actions for an editor are invalidated if the editor is
closed.
- Implemented switching to appropriate editor when undo/redo occurs.
- Implemented Undo/Redo of model changes.
- Updates DiagramExporterTest based on changes needed for the new action
system and to fail on exception.
- Added test for dirty state indicator.

philip-alldredge added a commit that referenced this issue Jun 19, 2018

Undo/Redo rework. (#1335)
* Undo/Redo rework.

Implements #1182, #1199, and #1246.

Replaces the current undo capability that is is
very limited with an implementation that allow undoing and redoing a
wider range of actions. Usage of the text editor can degrade
capabilities.

- Removed implementation of ICustomUndoRedoFeature. Graphiti undo/redo
no longer needed
- Removed ability to disable Graphiti modification listener. No longer
necessary with new undo implementation.
- Added undo support for add/remove element
- Added undo support for ghosting
- Added undo support for setDiagramConfiguration
- Added ActionService, AgeAction, and ActionExecutor
- Implemented global undo/redo stacks.
- Reworked interface between AgeDiagram, GraphitiAgeDiagram, and
AgeDiagramEditor to use AgeAction interface.
- Undo/Redo actions for an editor are invalidated if the editor is
closed.
- Implemented switching to appropriate editor when undo/redo occurs.
- Implemented Undo/Redo of model changes.
- Updates DiagramExporterTest based on changes needed for the new action
system and to fail on exception.
- Added test for dirty state indicator.

* Removed print statements from tests.

* Activate editor on undo fixes.
@philip-alldredge

This comment has been minimized.

Copy link
Collaborator

philip-alldredge commented Jun 19, 2018

Fixed in ebd75e1

@wafflebot wafflebot bot removed the next label Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.