Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiation always creates error markers #1255

Closed
lwrage opened this issue May 23, 2018 · 3 comments
Closed

Instantiation always creates error markers #1255

lwrage opened this issue May 23, 2018 · 3 comments
Assignees
@lwrage
Labels
category:enhancement core importance:high
Milestone
2.3.4

Comments

@lwrage
Copy link
Contributor

lwrage commented May 23, 2018

There should be a way to invoke instantiation without creating error markers on the instance model file.

child of #1018
needed by #603
@lwrage lwrage added this to the 2.3.4 milestone May 23, 2018
@lwrage lwrage self-assigned this May 23, 2018
@lwrage lwrage mentioned this issue May 23, 2018
Closed
@lwrage
Copy link
Contributor Author

lwrage commented May 30, 2018

So far we have an additional entry point that records errors instead of adding markers. This can be used for tests. We still need to update the other entry points.

@lwrage
Copy link
Contributor Author

lwrage commented May 31, 2018

There is no need to always save the instance model file.

@lwrage
Copy link
Contributor Author

lwrage commented May 31, 2018

The remaining work will be done under #603

@lwrage lwrage mentioned this issue Jun 1, 2018
Merged
@lwrage lwrage added review and removed in progress labels Jun 1, 2018
@ghost ghost removed the review label Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lwrage lwrage

Labels
category:enhancement core importance:high
Projects
None yet
Milestone
2.3.4
Development

No branches or pull requests
1 participant
@lwrage