New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annex processing assumes that it runs inside Eclipse #1257

Closed
lwrage opened this Issue May 25, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@lwrage
Contributor

lwrage commented May 25, 2018

Annex parsing is implemented in a rather weird way that requires it to run in Eclipse. As a consequence, we cannot parse AADL files standalone, for example, in tests. This needs to be redesigned from scratch. Maybe #619 is the way to go.

child of #1018
blocks #1254

@lwrage

This comment has been minimized.

Show comment
Hide comment
@lwrage

lwrage May 25, 2018

Contributor

Potential approaches to investigate:

  • Check if the workbench is running and use different error reporting depending on the result
  • Don't use markers but inject annex errors and warnings into xtext's way of handling them
  • Use Xtext derived state computer (see #619)
  • Use an annex builder
Contributor

lwrage commented May 25, 2018

Potential approaches to investigate:

  • Check if the workbench is running and use different error reporting depending on the result
  • Don't use markers but inject annex errors and warnings into xtext's way of handling them
  • Use Xtext derived state computer (see #619)
  • Use an annex builder

@wafflebot wafflebot bot added in progress and removed next labels May 25, 2018

@lwrage

This comment has been minimized.

Show comment
Hide comment
@lwrage

lwrage May 30, 2018

Contributor

For now, try minimal changes to existing implementation:

  • Use queuing error reporter for annex parsing/linking.
  • Make error reporters (except marker reporter) independent of Eclipse IResource.
  • Deprecate marker error reporters.
  • Don't process annexes if OSGI is not available. We rely on the extension registry, even for Xtext annexes. This can probably be improved later.
Contributor

lwrage commented May 30, 2018

For now, try minimal changes to existing implementation:

  • Use queuing error reporter for annex parsing/linking.
  • Make error reporters (except marker reporter) independent of Eclipse IResource.
  • Deprecate marker error reporters.
  • Don't process annexes if OSGI is not available. We rely on the extension registry, even for Xtext annexes. This can probably be improved later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment