Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Leaks in the Graphical Editor #1307

Closed
philip-alldredge opened this Issue Jun 8, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@philip-alldredge
Copy link
Collaborator

philip-alldredge commented Jun 8, 2018

There are global references to the graphical editor once an editor is closed. This prevents the objects from being garbage collected.

  • AgeDiagramBehavior - Post Selection Listener
  • AgeDiagramBehavior - Part Listener

There appears to be some other interaction with Eclipse that is occurring that is causing the editor to be retained until a new editor, textual or graphical, is opened. This latter issue will be ignored for now as it is uncertain whether that is normal Eclipse behavior.

@philip-alldredge philip-alldredge self-assigned this Jun 8, 2018

@philip-alldredge philip-alldredge added this to the 2.3.4 milestone Jun 8, 2018

philip-alldredge added a commit that referenced this issue Jun 8, 2018

Fixed #1307
Resolves multiple causes of objects not beeing garbage collected.

@wafflebot wafflebot bot added in progress review and removed in progress labels Jun 8, 2018

RyanMcilnay added a commit that referenced this issue Jun 11, 2018

#1307
 Null check added

@wafflebot wafflebot bot removed the review label Jun 12, 2018

@philip-alldredge philip-alldredge added the ge label Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.