New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual processor without properties is not included in flow latency report #1311

Closed
joeseibel opened this Issue Jun 12, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@joeseibel
Contributor

joeseibel commented Jun 12, 2018

If a component is bound to a virtual processor (aka partition) the partition becomes a latency contributor. However, if the partition does not have any property indicate its rate of execution it is not included in the report. It should be included with an indication that its contribution is zero due to missing property values.
Note: in other cases we do include the partition even though the contribution is zero, e.g., when the component bound to it is the first element of a flow.

package partition11
public
	system s1
	end s1;
	
	system implementation s1.i1
		subcomponents
			sub1: system s2;
			sub3: virtual processor {Period => 1 ms;};
			sub18: abstract a1;
			sub19: virtual processor;
		connections
			conn11: feature sub1.f1 -> sub18.f2;
		flows
			etef11: end to end flow sub1.fsource1 -> conn11 -> sub18.fsink1 {Latency => 5 ms .. 6 ms;};
		properties
			Actual_Processor_Binding => (reference (sub3)) applies to sub1;
			Actual_Processor_Binding => (reference (sub19)) applies to sub18;
	end s1.i1;
	
	system s2
		features
			f1: feature;
		flows
			fsource1: flow source f1 {Latency => 1 ms .. 2 ms;};
		properties
			Period => 1 ms;
	end s2;
	
	abstract a1
		features
			f2: feature;
		flows
			fsink1: flow sink f2 {Latency => 3 ms .. 4 ms;};
	end a1;
end partition11;

@joeseibel joeseibel added the analyses label Jun 12, 2018

@lwrage lwrage added this to the 2.3.5 milestone Jul 2, 2018

@lwrage lwrage added the next label Jul 2, 2018

@wafflebot wafflebot bot added in progress and removed next labels Jul 27, 2018

@wafflebot wafflebot bot added review and removed in progress labels Jul 27, 2018

@lwrage lwrage changed the title from Virtual processor without properties is not included in report to Virtual processor without properties is not included in flow latency report Jul 30, 2018

@lwrage lwrage closed this in #1409 Jul 30, 2018

@wafflebot wafflebot bot removed the review label Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment