Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical editor creates unneeded with statements. #1342

Closed
philip-alldredge opened this issue Jun 19, 2018 · 0 comments
Closed

Graphical editor creates unneeded with statements. #1342

philip-alldredge opened this issue Jun 19, 2018 · 0 comments
Assignees
Milestone

Comments

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Jun 19, 2018

When the text editor is open, setting the extended classifier graphically results in with statements being created regardless of the package. This results in duplicate with statements and with statements which reference the current package.

This is caused by multiple implementations of the logic to import a package if needed. AadlImportsUtil contains a working implementation and AadlHelper.ensurePackageIsImported() contains similar logic but compares packages by reference instead of by name. Need to cleanup. Both methods should share logic and be located in the same class.

@philip-alldredge philip-alldredge added this to the 2.3.4 milestone Jun 19, 2018
@philip-alldredge philip-alldredge self-assigned this Jun 19, 2018
philip-alldredge added a commit that referenced this issue Jun 20, 2018
Prevents creation of unneeded with statements in graphical editor.
Closes #1342.
@ghost ghost added the in progress label Jun 20, 2018
@ghost ghost added review and removed in progress labels Jun 20, 2018
philip-alldredge added a commit that referenced this issue Jun 20, 2018
…1350)

Prevents creation of unneeded with statements in graphical editor.
Closes #1342.
@ghost ghost removed the review label Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant