Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error message when installing an already installed OSATE component #1386

Closed
joeseibel opened this Issue Jul 16, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@joeseibel
Copy link
Contributor

joeseibel commented Jul 16, 2018

The Additional OSATE Components Discovery does not filter components that are already installed. If the user tries to install a component which is already installed, an error dialog with an unhelpful message is displayed.
osate_components_error
The error log contains a stack trace:

java.lang.RuntimeException: Operation details
	at org.eclipse.papyrus.infra.discovery.ui.internal.common.PrepareInstallProfileJob.resolve(PrepareInstallProfileJob.java:159)
	at org.eclipse.papyrus.infra.discovery.ui.internal.common.PrepareInstallProfileJob.run(PrepareInstallProfileJob.java:109)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:119)

We should gray out installed components in the discovery dialog or at least catch the exception and show a meaningful error message.

@lwrage

This comment has been minimized.

Copy link
Contributor

lwrage commented Jul 20, 2018

The Mylyn Connector Discovery has a better dialog that can filter installed components.

@lwrage lwrage added next backlog and removed next backlog labels Feb 14, 2019

@lwrage lwrage added this to the 2.4.1 milestone Feb 20, 2019

@wafflebot wafflebot bot added in progress and removed next labels Feb 26, 2019

@joeseibel

This comment has been minimized.

Copy link
Contributor Author

joeseibel commented Mar 5, 2019

TODO:

  • Build org.osate.discovery and put the built jar file online.
  • Point the directory xml file to the jar file.
  • Put the directory xml file online.
  • Point the org.eclipse.equinox.p2.ui.discovery.commands.ShowBundleCatalog menu entry to the discovery xml file.
  • Move the ShowBundleCategory menu entry from org.osate.discovery to org.osate.ui.
  • Remove org.osate.discovery from the OSATE product.
  • Delete project org.eclipse.papyrus.infra.discovery.
  • Delete project org.eclipse.papyrus.infra.discovery.ui.
  • Remove unneeded files from project org.osate.discovery.

@lwrage lwrage self-assigned this Mar 13, 2019

@wafflebot wafflebot bot added review and removed in progress labels Mar 16, 2019

@wafflebot wafflebot bot removed the review label Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.