New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable code in FlowLatencyAnalysisSwitch #1427

Closed
joeseibel opened this Issue Aug 2, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@joeseibel
Contributor

joeseibel commented Aug 2, 2018

There is a large section of unreachable code in FlowLatencyAnalysisSwitch.mapComponentInstance. The unreachable code is from line 216 to line 256.

The if condition on line 215, entry.getContributors().isEmpty(), only evaluates to true for the first segment of the flow. However, this is contained in another if which only executes for segments that have a previous connection. That condition is on line 189 and is fi != null.

Is there a bug somewhere and should this code actually be executed or should the unreachable code simply be removed? If I am wrong and the code can be executed, then please provide a model which executes that code.

@lwrage lwrage added this to the 2.3.5 milestone Aug 2, 2018

@lwrage lwrage added the next label Aug 2, 2018

@wafflebot wafflebot bot added in progress and removed next labels Aug 2, 2018

@wafflebot wafflebot bot added review and removed in progress labels Aug 3, 2018

@wafflebot wafflebot bot removed the review label Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment