Instantiation does not check overriding of constant property associations

[lwrage]

The instantiator should report an error if a contained property association overrides a property of an instance object that is marked as constant. Instance property associations already point to the declarative p.a. as their source. We need to check if that source is marked constant.

[AaronGreenhouse]

I verified that this does seem to be checked for all the obvious cases in the declarative model (without any contained property associations).

[AaronGreenhouse]

Checking the current behavior for contained property associations. The following case is caught as an error in the declarative model:

package i1447_instance
public
	with TestPS;

	system A
	end A;

	system B
	end B;

	system C
	end C;

	system D
	end D;

	system implementation A.i
		subcomponents
			s1: system B.i;
	end A.i;

	system implementation B.i
		subcomponents
			s2: system C.i;
	end B.i;

	system implementation C.i
		subcomponents
			s3: system D.i;
		properties
			TestPS::myProp => 1 applies to s3;
	end C.i;

	system implementation D.i
		properties
			TestPS::myProp => constant 0;
	end D.i;
end i1447_instance;

But the instantiate (on A.i) action runs without producing any errors.

However, if I move the contained property association up a level to B.i as

		properties
			TestPS::myProp => 1 applies to s2.s3;

there is not an error on the declarative model.

[AaronGreenhouse]

This case, where I have a contained property association replacing another contained property association, does not produce errors in the declarative model or during the instantiation of A.i:

package i1447_instance
public
	with TestPS;

	system A
	end A;

	system B
	end B;

	system C
	end C;

	system D
	end D;

	system implementation A.i
		subcomponents
			s1: system B.i;
	end A.i;

	system implementation B.i
		subcomponents
			s2: system C.i;
		properties
			TestPS::myProp => 2 applies to s2.s3;
	end B.i;

	system implementation C.i
		subcomponents
			s3: system D.i;
		properties
			TestPS::myProp => constant 1 applies to s3;
	end C.i;

	system implementation D.i
		properties
			TestPS::myProp => 0;
	end D.i;
end i1447_instance;

[AaronGreenhouse]

Case similar to the first one. Error on the declarative model, but nothing during instantiation.

package i1447_instance
public
	with TestPS;

	system A
	end A;

	system B
	end B;

	system C
	end C;

	system D
		properties
			TestPS::myProp => constant 0;
	end D;

	system implementation A.i
		subcomponents
			s1: system B.i;
	end A.i;

	system implementation B.i
		subcomponents
			s2: system C.i;
	end B.i;

	system implementation C.i
		subcomponents
			s3: system D.i;
		properties
			TestPS::myProp => 10 applies to s3;
	end C.i;

	system implementation D.i
	end D.i;
end i1447_instance;

Again, when I move the contained property association up a level to B.i there is no error on the declarative model.

[AaronGreenhouse]

Trying applies to on features now.

package i1447_instance
public
	with TestPS;

	data X
	end X;
	
	data Y extends X
	end Y;

	data implementation Y.i
	end Y.i;

	data implementation Y.j extends Y.i
	end Y.j;

	system A
	end A;

	system B
	end B;

	system C
	end C;

	system D
		features
			f1: out data port Y.j {
				TestPS::myProp => constant 100;
			};
	end D;

	system implementation A.i
		subcomponents
			s1: system B.i;
	end A.i;

	system implementation B.i
		subcomponents
			s2: system C.i;
	end B.i;

	system implementation C.i
		properties
			TestPS::myProp => 200 applies to s3.f1;
	end C.i;
end i1447_instance;

There are no errors of any sort reported here even though the contained property association in C.i tries to replace the constant property association that comes from D.

Also, if I mark the contained association in C.i as constant and add the following to B.i

			TestPS::myProp => 300 applies to s2.s3.f1;

there are no errors generated anywhere, even though I should not be able to replace the value associated in C.i.