Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a Mode throws ClassCastException #1449

Closed
philip-alldredge opened this Issue Aug 14, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@philip-alldredge
Copy link
Collaborator

philip-alldredge commented Aug 14, 2018

Summary

When renaming a mode with the graphical editor, a ClassCastException is thrown if that mode is referenced by a flow specification. We believe it is due to a problem with org.osate.aadl2.operations.ModalPathOperations#getInModes not returning the type expected by EMF. This is very similar to #1021.

Steps to Reproduce

  1. Create diagram for model below.
  2. Rename m1 to m1_renamed using the graphical editor.
  3. A window will appear reporting the error and indicating that the rename participant provided by the graphical editor will not be used in the future.
    Exception.txt
package bug
public
	system top
		features
			i1: in data port;
		flows
			fsnk: flow sink i1 in modes (m1);
		modes
			m1: mode;
	end top;
end bug;

Environment

  • OSATE Version: develop
  • Operating System: Windows 10
@lwrage

This comment has been minimized.

Copy link
Contributor

lwrage commented Aug 15, 2018

Need to check if there are more usages of BasicInternalEList that need to be replaced.

@lwrage lwrage added the next label Aug 15, 2018

@lwrage lwrage self-assigned this Aug 16, 2018

@wafflebot wafflebot bot added in progress and removed next labels Aug 16, 2018

@wafflebot wafflebot bot added review and removed in progress labels Aug 16, 2018

@lwrage lwrage added the core label Aug 17, 2018

@lwrage lwrage closed this in #1455 Aug 17, 2018

@wafflebot wafflebot bot removed the review label Aug 17, 2018

@philip-alldredge

This comment has been minimized.

Copy link
Collaborator Author

philip-alldredge commented Aug 30, 2018

The fix for this(#1455) caused additional issues. Similar to the way the fix for #1021 caused a write transaction error, this can cause a write transaction error in certain circumstances. @RyanMcilnay will provide additional details.

@RyanMcilnay

This comment has been minimized.

Copy link
Contributor

RyanMcilnay commented Aug 30, 2018

While editing a model, I received a write transaction error while the model was being serialized. It was triggered by creating a classifier implementation with Modes and ModalElements, then selecting a mode from the the highlight-in-mode drop-down in the toolbar.

I have attached the stack trace.
IllegalStateException_Stack_Trace.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.