Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSATE Graphical Editor should move bend points when both ends are moved together #1476

Closed
smithdtyler opened this issue Aug 23, 2018 · 5 comments
Closed

Comments

@smithdtyler
Copy link

@smithdtyler smithdtyler commented Aug 23, 2018

When I select a group of objects in an AADL diagram and move them, anchor points on flows and connections between the objects don't move with them. By anchor points I'm referring to "turns" in the line connecting the two objects.

When both objects connected by a flow/connection/etc are moved, all anchor points on that flow/connection should move too.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Aug 23, 2018

To clarify things: this affects when the container itself isn't moving. For example, when two subcomponents move, the connection isn't updated. However, when the container is moved then the connections are updated appropriately. Is this correct?

Loading

@smithdtyler
Copy link
Author

@smithdtyler smithdtyler commented Aug 23, 2018

@philip-alldredge not quite. Here's an example of the problem with pictures:

  1. Start from the example producer-consumer model:

screen shot 2018-08-23 at 10 16 52 am

  1. Select the two processes and drag them down.

screen shot 2018-08-23 at 10 17 17 am

  1. The anchor on the connection between them does not move.

screen shot 2018-08-23 at 10 17 26 am

This even happens when I select the connection

screen shot 2018-08-23 at 10 17 34 am

screen shot 2018-08-23 at 10 17 41 am

Loading

@smithdtyler
Copy link
Author

@smithdtyler smithdtyler commented Aug 23, 2018

What should happen is the arrow should maintain its shape, as (mocked up) below:
screen shot 2018-08-23 at 10 16 52 am
screen shot 2018-08-23 at 10 21 59 am

Loading

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Aug 23, 2018

I think we are in agreement. Your example is the same as I (attempted) to describe in my comment. I was trying to clarify the case where the issue occurs. However, your example does a good example at illustrating it.

Loading

@philip-alldredge philip-alldredge changed the title OSATE Graphical Editor should move arrow anchors when both ends are moved together OSATE Graphical Editor should move bendpoints when both ends are moved together Dec 21, 2018
@philip-alldredge philip-alldredge changed the title OSATE Graphical Editor should move bendpoints when both ends are moved together OSATE Graphical Editor should move bend points when both ends are moved together Dec 21, 2018
@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Jun 14, 2019

We also need to consider how the implementation of this affects the alignment tools and other tools that perform shape movement.

Loading

philip-alldredge added a commit that referenced this issue Jul 12, 2019
Fix issue #1476. Adjusts handling of moving elements.
@lwrage lwrage added this to the 2.6.0 milestone Jul 22, 2019
@lwrage lwrage moved this from Proposed to Done in Graphical Editor Enhancements 2019 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants