New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a modal path to in-mode does not reflect change #1493

Closed
RyanMcilnay opened this Issue Sep 4, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@RyanMcilnay
Contributor

RyanMcilnay commented Sep 4, 2018

Summary

When setting a modal path to in-mode using the graphical editor AADL properties view, no change occurs. The in-mode looks like it is set and then removed simultaneously.
We suspect it has something to do with the latest changes made for #1449.

Steps to Reproduce

  1. Create type classifier
  2. Create mode, feature, and flow spec
  3. Select the flow spec
  4. Open properties view
  5. Click the mode in the in-mode section
package Test
public
	abstract t
		features
			feat: in feature;
		flows
			f_sink: flow sink feat;
		modes
			m1: mode;
	end t;
end Test;

Environment

  • OSATE Version: 2.3.5 Release
  • Operating System: Windows 10
@philip-alldredge

This comment has been minimized.

Collaborator

philip-alldredge commented Sep 4, 2018

This is a regression from 2.3.4. I suspect it has something to do with out Xtext updates the resource after changes to the model. The model change does not cause a change in the AADL source.

@RyanMcilnay please open an issue for creating an automated test to detect such regressions.

@philip-alldredge philip-alldredge changed the title from Setting a modal path to in-mode does reflect change to Setting a modal path to in-mode does not reflect change Sep 27, 2018

@lwrage lwrage added this to the 2.3.6 milestone Sep 28, 2018

@lwrage lwrage self-assigned this Sep 28, 2018

@lwrage lwrage added the next label Oct 1, 2018

@wafflebot wafflebot bot added in progress and removed next labels Oct 1, 2018

@wafflebot wafflebot bot added review and removed in progress labels Oct 1, 2018

@lwrage lwrage closed this in #1561 Oct 5, 2018

@wafflebot wafflebot bot removed the review label Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment