Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to add all elements that are connected to a selected element #1543

Closed
lwrage opened this issue Sep 21, 2018 · 7 comments
Closed

Add action to add all elements that are connected to a selected element #1543

lwrage opened this issue Sep 21, 2018 · 7 comments

Comments

@lwrage
Copy link
Contributor

@lwrage lwrage commented Sep 21, 2018

No description provided.

@RyanMcilnay
Copy link
Contributor

@RyanMcilnay RyanMcilnay commented Feb 5, 2020

@philip-alldredge @lwrage Current thoughts for implementation is to add a context menu item for ConnectionEnds/ConnectionInstanceEnds that will show continuous connected elements in the ancestors and children.

@lwrage Any thoughts or concerns?

@lwrage
Copy link
Contributor Author

@lwrage lwrage commented Feb 5, 2020

I'm not sure I understand what you mean by ancestors and children.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Feb 5, 2020

@lwrage @RyanMcilnay can clarify but...

We are ultimately trying to decide how this feature should work given the name of the issue. The current idea is that if a connection end is selected and the menu item is used, it will show all connections that reference it and the other end of the connection.

The question we had was whether selecting a subcomponent and using the menu item should show features and everything connected to those features. My feeling is that behavior would be too broad and that it shouldn't do that. However, we don't know the original source of this request. We can also add that capability later once users have experience with this feature.

@lwrage
Copy link
Contributor Author

@lwrage lwrage commented Feb 5, 2020

@philip-alldredge IIRC, what you just described as too broad was the original idea behind the issue. This looks like a topic for a telecon.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Feb 5, 2020

If that's the case then that is fine. The too broad comment was mostly just my initial feelings on it. I didn't want to introduce features in the absence of a well defined scope.

@lwrage @RyanMcilnay I'd recommend setting up a telecon between the two of you. I will attend as my availability allows but I would prefer not to hold things up on my account. I'd like to update this issue when it is resolved though.

Is the intention for this to only be applicable to subcomponents or to both subcomponents and any connection ends?

@RyanMcilnay
Copy link
Contributor

@RyanMcilnay RyanMcilnay commented Feb 6, 2020

@lwrage Disregard the child/ancestor comment, it was based off of a misunderstanding.

I put a few examples together of how this action would behave. The action would be applicable to Subcomponents and ConnectionEnds.

If this is an acceptable approach, I'll continue in this direction.
If there are any concerns, just send me an email we can discuss on the phone.

This is the full diagram.
diagram

Before showing connections of ss1.
hidden

After showing connections of ss1.
full_diagram

Before showing sys1.d_i connections.
mid_feature_selected

After showing sys1.d_i connections.
mid_feature

@lwrage
Copy link
Contributor Author

@lwrage lwrage commented Feb 11, 2020

I think this is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants