Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to show all elements that participate in a flow or mode to a diagram #1544

Closed
lwrage opened this issue Sep 21, 2018 · 6 comments
Closed

Comments

@lwrage
Copy link
Contributor

@lwrage lwrage commented Sep 21, 2018

No description provided.

@lwrage lwrage added the ge label Sep 21, 2018
@philip-alldredge philip-alldredge changed the title Add action to show add all elents that participate in a flow or mode to a diagram Add action to show add all elements that participate in a flow or mode to a diagram Sep 21, 2018
@lwrage lwrage removed the epic label Sep 21, 2018
@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Oct 15, 2018

@lwrage is this idea for this to be just a shortcut for manually adding elements to the diagram or something that is more dynamic/persistent? In other words, if the flow or mode changes, should the set of elements shown in the diagram change as well or should the user have to manually add the new elements/repeat the operation?

@philip-alldredge philip-alldredge changed the title Add action to show add all elements that participate in a flow or mode to a diagram Add action to show all elements that participate in a flow or mode to a diagram Jul 2, 2019
@philip-alldredge philip-alldredge added this to the 2.7.1 milestone Jan 7, 2020
@RyanMcilnay
Copy link
Contributor

@RyanMcilnay RyanMcilnay commented Jan 8, 2020

@lwrage Current thoughts for implementation are to add a toolbar button that will show the elements that participate in the currently selected flow in the highlight flow combobox.

Modes are selectable on the diagram so a context menu option would be added to show in mode elements.

Does this seem like an acceptable approach?

Notes: Disable/Enable button when whole/partial flows are selected

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Jan 8, 2020

That seems like it would acceptable to me.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Jan 23, 2020

@RyanMcilnay I noticed that the flow drop down does not show flows when there are no elements that would highlighted in the current diagram. For example if a subcomponent contains an end-to-end flow but its contents are not being displaced, the flow is not selectable. We need to adjust this to show such flows. I believe a general rule would be that if the container is visible, then we should show it.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Jan 23, 2020

@RyanMcilnay i'm working with an out of date version, but please verify that undo and redo works correctly. It should be labeled based on the operation being performed and there should only be one undo required to undo the entire operation. This is not the case with the currently pushed version.

@lwrage
Copy link
Contributor Author

@lwrage lwrage commented Jan 23, 2020

Looks good to me.

Graphical Editor Enhancements automation moved this from Increment 1 - 2020-02-28 to Done Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants