New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In modes clause attached to connection is missing when saving an AADL model #1551

Closed
Etienne13 opened this Issue Sep 26, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Etienne13
Contributor

Etienne13 commented Sep 26, 2018

Summary

I have a model transformation in which I produce a port connection with an in mode clause by adding a mode value to the inModeOrTransition field:

Connection cnx;
cnx.getInModeOrTransition.add(myMode); // myMode is of type Mode.

latter I save the model using the OsateResourceUtil.saveFormatted method.

Expected and Current Behavior

I expect to have something like this in the aadl module that is produced:

...
connections
cnx: port src->dst in modes(my_mode);

but the "in modes" clause is missing. I tried with an aadl unparser we developped some time ago and the "in modes" clause is correct in this case.

Steps to Reproduce

I guess the easiest way is to

  1. load an aadl model containing an "in modes" clause attached to a connection
  2. create a new resource, with a new URI
  3. call the OsateResourceUtil.saveFormatted on this new resource.
package test_cnx_per_mode

   system root
  end root;

  system implementation root.impl
  subcomponents
    the_proc_modes: process proc1.impl;
  end root.impl;

  process proc1
  end proc1;

  process implementation proc1.impl
  subcomponents
    the_receiver: thread receiver;
    c11: data Integer {Data_Model::Initial_Value=>("11");};
  connections
    cnx2: port c11 -> the_receiver.input_data in modes (m1);
  modes
    m1: initial mode;
    m2: mode;
  end proc1.impl;

  thread receiver
  features
    input_data: in data port Integer;
  end receiver;

  data Integer
  end Integer;

end test_cnx_per_mode;

Environment

  • OSATE Version: 2.3.5
  • Operating System: Linux
@philip-alldredge

This comment has been minimized.

Collaborator

philip-alldredge commented Sep 27, 2018

Could this be the cause or related to #1493?

@lwrage lwrage added this to the 2.3.6 milestone Sep 28, 2018

@lwrage lwrage self-assigned this Sep 28, 2018

@wafflebot wafflebot bot added review and removed next labels Oct 1, 2018

@lwrage lwrage added the core label Oct 3, 2018

@lwrage lwrage closed this Oct 5, 2018

@wafflebot wafflebot bot removed the review label Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment