Redesign reinstantiation handlers

[joeseibel]

The current state of instantiation and reinstantation handlers is confusing and it seems that it was created in an ad-hoc manner. We should think about what would make sense.

There are three handlers for instantiation: InstantiateHandler, ReinstantiateAadl, and ReinstantiateHandler. We should use more meaningful names so that it can be obvious what the difference between ReinstantiateAadl and ReinstantiateHandler is. Some of the functionality is confusing as well.

• InstantiateHandler: This is in the outline view's context menu with the label "Instantiate" and is invoked on one ComponentImplementation.
• ReinstantiateAadl: This is in the main menu with the label "Reinstantiate All Instance Models". The behavior is dependent on the selection. If the selection contains instance IFiles, then only those instance files are reinstantiated. This is confusing because the behavior does not match the label and it will not reinstantiate all instance models in the workspace. If the selection does not contain any instance files, then all instances models in the workspace will be reinstantiate. This handler needs to change because the behavior is confusing and not obvious to the user. "Reinstantiate All" should not care about the selection.
• ReinstantiateHandler: This is in the navigator's context menu with the label "Reinstantiate" and is invoked on one IFile which is an instance file. This could be modified to allow multiple instance files to be selected.

One functionality to think about is reinstantiating all instances in a selected IContainer or working set. There could be a dialog showing which files were reinstantiated or indicating that there were no instance files contained in the selection.

We are also not consistent with how progress is handled. InstantiateHandler is run in a ProgressMonitorDialog. ReinstantiateAadl is run in a WorkspaceJob. ReinstantiateHandler is executed directly without any progress reporting.

[lwrage]

Note: Should support reinstantiation from navigator if a directory/project/working set is selected. In this case find all instance models in directory/project/working set and reinstantiate all of them.

[AaronGreenhouse]

What we have now in the UI:

• Selecting a single ComponentImplementaton in the "Outline" view shows "Instantiate" in the context menu.
  • There is no option to instantiate multiple items
• Selecting a single .aaxl file in the "AADL Navigator" view shows "Instantiate" in the context menu.
  • There is no option to instantiate multiple items
• There is no menu item in the "OSATE" menu bar to instantiate a component.
• Selecting a single "ComponentInstace" in the "AADL Navigator" view sows "Reinstantiate" in the context menu.
  • There is no option to instantiate multiple items
• We have "Reinstantiate All Instance Models" in the "OSATE" menu bar at all times.

[AaronGreenhouse]

What we probably want:

• Selecting 1 or more ComponentImplementation objects in the "Outline" view enables "Instantiate Component" in the context menu and "Instantiate Component" in the "OSATE" menu bar. Each selected component is separately instantiated.
• Selecting 1 or more ComponentImplementation objects in the "AADL Navigator" view enables "Instantiate Component" in the context menu and "Instantiate Component" in the "OSATE" menu bar. Each selected component is separately instantiated.
• Selecting exactly 1 SystemInstance object in the "AADL Navigator", aaxl editor, or "Outline" view, or should
  • Enable "Reinstantiate Instance Model" in the "OSATE" menu bar
  • Enable "Reinstantiate Instance Model" in the appropriate context menu
• Selecting exactly 1 .aaxl file in the "AADL Navigator" should
  • Enable "Reinstantiate Instance Model" in the "OSATE" menu bar
  • Enable "Reinstantiate Instance Model" in the appropriate context menu
• Selecting 2 or more .aaxl files or SystemInstance objects in the "AADL Navigator" should
  • Enable "Reinstantiate Instance Model" in the "OSATE" menu bar
  • Enable "Reinstantiate Instance Model" in the context menu
• Selecting 1 or more non-nested projects, directories, or working sets in the "AADL Navigator" should
  • Enable "Reinstantiate All Instance Models" in the context menu
  • Enable "Reinstantiate All Instance Models" in the "OSATE" menu bar.

When executed, this searches for all instance models in the selected objects and reinstantiates each one.

• When nothing is selected none of the instantiate/reinstantiate commands should be enabled in the "OSATE" menu bar.

[AaronGreenhouse]

I think the correct way to run all these items is as a WorkspaceJob. This is the way to execute items in the Eclipse workspace and prevent them concurrently making changes.

[lwrage]

Also, all this needs to be cancellable because instantiation may take a long time.

[lwrage]

How will we reinstantiate all instance model in the workspace?

[AaronGreenhouse]

Okay, yes, I forgot about just reinstantiating everything in the workspace. How about

• Selecting 1 or more non-nested projects, directories, or working sets in the "AADL Navigator" should
  • Enable "Reinstantiate All Instance Models in Selection" in the context menu
  • Enable "Reinstantiate All Instance Models in Selection" in the "OSATE" menu bar.

When executed, this searches for all instance models in the selected objects and reinstantiates each one.

• There should always be a "Reinstantiate All Instance Models in Workspace" command in the "AADL Navigator" context menu and the "OSATE" menu bar.

If you don't like the really long menu item names we could have two sub menus:

• Reinstantitae All Instance Models > In Selection and
• Reinstantitae All Instance Models > In Workspace

[lwrage]

Never mind, we can always select everything (Ctrl-A) in the navigator and reinstantiate. Maybe it would it be clearer to just have on Reinstantiate instead of Reinstantiate and Reinstantiate all.

[AaronGreenhouse]

We can work on this. Right now I'm trying to fix up initial instantiation.

[AaronGreenhouse]

Created new InstantiateComponentHandler. It's used by "Instantiate Component" in

• the outline view
• the AADL Navigator
• the "OSATE" drop down menu

It instantiates 1 or more component implementations. Error messages are bundled up and reported at the end, although I'm not sure how to test this. Should support cancellation, but my test models aren't complicated enough for the progress monitor to show and be cancelled.

[lwrage]

You can make instantiation take long by adding an array of modal components such that you end up with a huge number of SOMs. Don't forget to increase the SOM limit preference setting.